Fix running plugins with bad world name #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui2 #107 +/- ##
============================================
+ Coverage 60.43% 60.88% +0.45%
============================================
Files 16 16
Lines 2108 2135 +27
============================================
+ Hits 1274 1300 +26
- Misses 834 835 +1
Continue to review full report at Codecov.
|
JShep1
approved these changes
Aug 17, 2020
Merged
nkoenig
pushed a commit
that referenced
this pull request
Aug 19, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org>
nkoenig
added a commit
that referenced
this pull request
Aug 19, 2020
Revert pull request #107 due to breaking changes in Blueprint
chapulina
added a commit
that referenced
this pull request
Aug 19, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unforeseen consequence of #104 + gazebosim/gz-sim#278 is that users who already had old
~/.ignition/gazebo/gui.configfiles wouldn't be able to load the worlds that now have no<gui>element, because of the topic mismatch.So this PR adds a check and ignores topics and services that are explicitly defined, but don't match
worldName.For example, when the user has
<topic>/world/default/stats</topic>on theirgui.config, and tries to loadshapes.sdf, we load the plugin with the correct/world/shapes/statstopic, and print a warning.