Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix qt5 anchor warnings #126

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Fix qt5 anchor warnings #126

merged 1 commit into from
Sep 23, 2020

Conversation

luca-della-vedova
Copy link
Member

Same as the ign-gazebo PR, fixes the QT5 warnings at simulation starting time caused by the WorldControl plugin:

[ign-8] [GUI] [Wrn] [Application.cc:649] [QT] file::/WorldControl/WorldControl.qml:88:3: QML RoundButton: Detected anchors on an item that is managed by a layout. This is undefined behavior; use Layout.alignment instead.

@luca-della-vedova
Fix qt anchor warnings
b74ac3d 
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
@luca-della-vedova luca-della-vedova added bug Something isn't working 🔮 dome Ignition Dome beta Targeting beta release of upcoming collection labels Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020 •
edited
Loading

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   63.23%   63.23%           
=======================================
  Files          20       20           
  Lines        2592     2592           
=======================================
  Hits         1639     1639           
  Misses        953      953

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a03905...b74ac3d. Read the comment docs.

chapulina
chapulina approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chapulina chapulina merged commit 22434e2 into master Sep 23, 2020
@chapulina chapulina deleted the luca/qt_anchor_warnings branch September 23, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luca-della-vedova @chapulina