Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize single channel 8 bit image data #176

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 5, 2021

Signed-off-by: Ian Chen ichen@osrfoundation.org

Summary

Extended Image Display plugin to support visualizing single channel 8 bit unsigned integer data in a similar way to the 16 bit data. This is used by gazebosim/gz-sim#614 to visualize 8 bit thermal image data (see PR for screenshot)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #176 (7294517) into ign-gui4 (1190ed0) will decrease coverage by 0.80%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gui4     #176      +/-   ##
============================================
- Coverage     61.57%   60.77%   -0.81%     
============================================
  Files            21       21              
  Lines          2803     2840      +37     
============================================
  Hits           1726     1726              
- Misses         1077     1114      +37     
Impacted Files Coverage Δ
src/plugins/image_display/ImageDisplay.cc 18.87% <0.00%> (-4.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1190ed0...c7b0fce. Read the comment docs.

@adlarkin adlarkin self-requested a review February 5, 2021 15:27
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@adlarkin
Copy link
Contributor

adlarkin commented Feb 9, 2021

I think this is good to go - do we need to add some sort of test?

Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are currently no tests for pixel formats with image display (https://github.com/ignitionrobotics/ign-gui/blob/a60cb7d61339b407ff3285ddbf16f618c4c4b3b9/src/plugins/image_display/ImageDisplay_TEST.cc), I think that this is fine as is. Perhaps we can add some tests later if people think that would be a worthwhile contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants