Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated thermal camera tutorial: include varying temperature objects #79

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Jan 14, 2021

I've updated the thermal camera tutorial to reflect the thermal camera updates for heat signatures (gazebosim/gz-rendering#189 and gazebosim/gz-sim#498). I also updated the tutorial to reflect 8-bit vs 16-bit functionality (#79 (comment)).

Signed-off-by: Ashton Larkin ashton@openrobotics.org

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #79 (c999f98) into ign-sensors4 (b60c815) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-sensors4      #79   +/-   ##
=============================================
  Coverage         76.13%   76.13%           
=============================================
  Files                23       23           
  Lines              2388     2388           
=============================================
  Hits               1818     1818           
  Misses              570      570           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60c815...c999f98. Read the comment docs.

@adlarkin adlarkin self-assigned this Jan 14, 2021
tutorials/03_thermal_camera.md Outdated Show resolved Hide resolved
tutorials/03_thermal_camera.md Outdated Show resolved Hide resolved
tutorials/03_thermal_camera.md Outdated Show resolved Hide resolved
@adlarkin adlarkin marked this pull request as draft February 18, 2021 15:14
@adlarkin
Copy link
Contributor Author

adlarkin commented Feb 18, 2021

I'm converting this to a draft for now because the tutorial needs to be updated to reflect the recent additions to the thermal camera (mainly, the option for 8-bit format). I'll re-visit this soon.

I believe that what's currently missing is material from the following PRs:

@@ -94,7 +95,12 @@ This is currently unused by Ignition Gazebo.
Now that we have set up our thermal camera, we'll need to assign temperatures to models in the environment.
If a model doesn't have a temperature associated with it, then the thermal camera cannot detect it.
Copy link
Contributor Author

@adlarkin adlarkin Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is a true statement any more since we now have gazebosim/gz-rendering#211

cc @iche033

Copy link
Contributor

@iche033 iche033 Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new behavior in Dome:

If a model doesn't have a temperature associated with it, then it will be assigned the ambient temperature. There will some variation in their temperature based on their color and the world's temperature gradient.

Copy link
Contributor Author

@adlarkin adlarkin Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in fadf90b

@adlarkin adlarkin marked this pull request as ready for review February 18, 2021 19:42
@adlarkin
Copy link
Contributor Author

I'm converting this to a draft for now because the tutorial needs to be updated to reflect the recent additions to the thermal camera (mainly, the option for 8-bit format). I'll re-visit this soon.

The tutorial has been updated in 2c53bff to reflect the 8-bit functionality, so this should be ready for another round of review.


One thing to note is that with my current setup (gazebo 4.5.0, rendering 4.5.0, gui 4.2.0, and sdformat 10.2.0 all installed as binary packages), running ign gazebo -r thermal_camera.sdf as instructed in the tutorial results in the following error:

[Err] [Server.cc:181] Error Code 8 Msg: Camera sensor <image><format> has invalid value of L16
[Err] [Server.cc:181] Error Code 8 Msg: Failed to load a world.

This can be resolved temporarily by downloading the SDF file and removing this line (thermal cameras use 16-bit format by default), but the proper workaround is to use sdformat 10.3.0 once it's released (gazebosim/sdformat#498). So, we probably shouldn't merge this until the sdformat 10.3.0 release is out.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a couple sentences showing how to set the ambient temperature and temperature gradient in sdf?
https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo4/examples/worlds/thermal_camera.sdf#L136

the <temperature_gradient> is used to give some variation to the temperature for objects without a uniform or heat signature set: gazebosim/gz-sim#578

@@ -94,7 +95,12 @@ This is currently unused by Ignition Gazebo.
Now that we have set up our thermal camera, we'll need to assign temperatures to models in the environment.
If a model doesn't have a temperature associated with it, then the thermal camera cannot detect it.
Copy link
Contributor

@iche033 iche033 Feb 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new behavior in Dome:

If a model doesn't have a temperature associated with it, then it will be assigned the ambient temperature. There will some variation in their temperature based on their color and the world's temperature gradient.

@adlarkin
Copy link
Contributor Author

adlarkin commented Feb 25, 2021

can you add a couple sentences showing how to set the ambient temperature and temperature gradient in sdf?

Addressed in fadf90b, and sdformat 10.3.0 has been released, so this is ready to be merged (pending approval)

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@adlarkin adlarkin force-pushed the adlarkin/varying_temp_thermal_tutorial branch from fadf90b to c999f98 Compare February 26, 2021 22:57
@adlarkin adlarkin merged commit c999f98 into ign-sensors4 Feb 26, 2021
@adlarkin adlarkin deleted the adlarkin/varying_temp_thermal_tutorial branch February 26, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants