Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeowners #251

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Fix codeowners #251

merged 1 commit into from
Jul 13, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jul 13, 2021

Signed-off-by: Louise Poubel louise@openrobotics.org

🦟 Bug fix

Summary

Oops, made the same mistake as in ign-cmake, fixed in gazebosim/gz-cmake#155. Each rule should be in a single line.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from jennuine as a code owner July 13, 2021 01:00
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 13, 2021
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #251 (d60fc2f) into ign-gui3 (3468008) will not change coverage.
The diff coverage is n/a.

❗ Current head d60fc2f differs from pull request most recent head 7fa7f9e. Consider uploading reports for the commit 7fa7f9e to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #251   +/-   ##
=========================================
  Coverage     65.71%   65.71%           
=========================================
  Files            23       23           
  Lines          2835     2835           
=========================================
  Hits           1863     1863           
  Misses          972      972           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3468008...7fa7f9e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants