Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeowners #613

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Conversation

WilliamLewww
Copy link
Contributor

🦟 Bug fix

Summary

Also made the same mistake as in 'ign-cmake' and 'ign-gui'.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Apr 22, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the tradition 😄

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #613 (ac5a917) into ign-rendering3 (25e51e2) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           ign-rendering3     #613   +/-   ##
===============================================
  Coverage           80.00%   80.00%           
===============================================
  Files                   1        1           
  Lines                  15       15           
===============================================
  Hits                   12       12           
  Misses                  3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e51e2...ac5a917. Read the comment docs.

@chapulina chapulina merged commit a4549be into gazebosim:ign-rendering3 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants