-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Scene3D 💥 if another scene is already loaded #347
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…ionrobotics/ign-gui into chapulina/3/graceful_scene3d Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #347 +/- ##
============================================
- Coverage 66.83% 66.77% -0.06%
============================================
Files 25 25
Lines 2964 2992 +28
============================================
+ Hits 1981 1998 +17
- Misses 983 994 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in these two files are unrelated:
- src/plugins/scene3d/Scene3D.qml
- test/integration/scene3d.cc
This is necessary to display a message to the user about why the plugin failed loading.
At first I thought that this PR had made the tests less precise, so I relaxed the tolerances. I don't understand how that could be the case though, I think that test may be flaky even without that PR. I could break that into another PR if it's clearer, but since I have the approval I'll go ahead and merge now. |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1 |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1 |
🦟 Bug fix
Summary
Current issue:
ign gazebo
Scene 3D
This PR prevents a crash and prints a message explaining to the user what happened.
The message will be printed if there's any other plugin already loading a render engine, so it's compatible with both
GzScene3D
andScene3D
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸