Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .cc extension to suppress CMake warnings #428

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Jun 28, 2022

🦟 Bug fix

Summary

Newer versions of CMake explicitly require extensions on all files.

Without extensions, you get warnings:

CMake Warning (dev) at /home/mjcarroll/workspaces/gz_garden/install/share/cmake/gz-cmake3/cmake3/IgnUtils.cmake:1742 (add_executable):
  Policy CMP0115 is not set: Source file extensions must be explicit.  Run
  "cmake --help-policy CMP0115" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  File:

    /home/mjcarroll/workspaces/gz_garden/src/gz-gui/src/Application_TEST.cc
Call Stack (most recent call first):
  /home/mjcarroll/workspaces/gz_garden/install/share/cmake/gz-cmake3/cmake3/IgnUtils.cmake:1854 (gz_build_executables)
  src/CMakeLists.txt:46 (gz_build_tests)
This warning is for project developers.  Use -Wno-dev to suppress it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll self-assigned this Jun 28, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 28, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • you need to remove the .cc from line 43
  • or add only .cc in line 48 and remove your changes

@ahcorde ahcorde mentioned this pull request Jun 28, 2022
8 tasks
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #428 (febafb0) into main (05f4bec) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   64.03%   64.07%   +0.03%     
==========================================
  Files          45       45              
  Lines        5539     5539              
==========================================
+ Hits         3547     3549       +2     
+ Misses       1992     1990       -2     
Impacted Files Coverage Δ
src/plugins/scene3d/Scene3D.cc 49.81% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f4bec...febafb0. Read the comment docs.

@mjcarroll mjcarroll merged commit 4fd1c86 into main Jun 29, 2022
@mjcarroll mjcarroll deleted the cmake_extensions branch June 29, 2022 16:22
chapulina pushed a commit that referenced this pull request Aug 11, 2022
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@chapulina chapulina mentioned this pull request Aug 11, 2022
8 tasks
chapulina added a commit that referenced this pull request Aug 11, 2022
* Add .cc extension to suppress CMake warnings (#428)

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Fix -Wfree-nonheap-object

Signed-off-by: Louise Poubel <louise@openrobotics.org>

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants