-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .cc extension to suppress CMake warnings #428
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- you need to remove the .cc from line 43
- or add only .cc in line 48 and remove your changes
Codecov Report
@@ Coverage Diff @@
## main #428 +/- ##
==========================================
+ Coverage 64.03% 64.07% +0.03%
==========================================
Files 45 45
Lines 5539 5539
==========================================
+ Hits 3547 3549 +2
+ Misses 1992 1990 -2
Continue to review full report at Codecov.
|
Signed-off-by: Michael Carroll <michael@openrobotics.org>
* Add .cc extension to suppress CMake warnings (#428) Signed-off-by: Michael Carroll <michael@openrobotics.org> * Fix -Wfree-nonheap-object Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org>
🦟 Bug fix
Summary
Newer versions of CMake explicitly require extensions on all files.
Without extensions, you get warnings:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.