Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings on Jammy #464

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Fix warnings on Jammy #464

merged 2 commits into from
Aug 11, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

We also support Fortress on Jammy, and these have been showing up.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

mjcarroll and others added 2 commits August 11, 2022 09:33
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the bug Something isn't working label Aug 11, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #464 (093690b) into ign-gui6 (c9b9fc0) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 093690b differs from pull request most recent head 0887125. Consider uploading reports for the commit 0887125 to get more accurate results

@@             Coverage Diff              @@
##           ign-gui6     #464      +/-   ##
============================================
+ Coverage     67.97%   68.00%   +0.03%     
============================================
  Files            39       39              
  Lines          5239     5239              
============================================
+ Hits           3561     3563       +2     
+ Misses         1678     1676       -2     
Impacted Files Coverage Δ
src/plugins/scene3d/Scene3D.cc 49.87% <0.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina chapulina merged commit eef3853 into ign-gui6 Aug 11, 2022
@chapulina chapulina deleted the chaapulina/6/428 branch August 11, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants