-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward-port 3 to 6 #434
Forward-port 3 to 6 #434
Conversation
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* common widget GzColor * implement Grid3D with the common widget Signed-off-by: youhy <haoyuan2019@outlook.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
* Example running a dialog before the main window Signed-off-by: Louise Poubel <louise@openrobotics.org> * Revert FIXMEs Signed-off-by: Louise Poubel <louise@openrobotics.org>
* Add common widget pose GUI Signed-off-by: youhy <haoyuan2019@outlook.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
* common widget variables fix * remove spacer * change show to expand Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: Mohamad <mohamad@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: youhy <haoyuan2019@outlook.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: youhy <haoyuan2019@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the example that needs to be updated. You can do that as a new commit to this branch, suffixed with (#434)
so we can trace it back to this PR.
Signed-off-by: youhy <haoyuan2019@outlook.com>
This test is failing: gz-gui/test/integration/minimal_scene.cc Line 158 in 2ba68b8
@chapulina should Haoyuan update the test to use |
Yeah I see it's very close,
|
Signed-off-by: youhy <haoyuan2019@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with happy CI. Remember to merge with commit, don't squash or rebase 😉
Codecov Report
@@ Coverage Diff @@
## ign-gui6 #434 +/- ##
=============================================
+ Coverage 30.54% 65.89% +35.34%
=============================================
Files 41 39 -2
Lines 1748 5257 +3509
=============================================
+ Hits 534 3464 +2930
- Misses 1214 1793 +579 Continue to review full report at Codecov.
|
➡️ Forward port
Port ign-gui3 to ign-gui6
Branch comparison: ign-gui6...ign-gui3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)