Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pose in Grid3d with GzPose #461

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Conversation

AzulRadio
Copy link
Contributor

Signed-off-by: youhy haoyuan2019@outlook.com

New feature

Summary

As title. The behavior should be exactly the same as before.

grid3d_pose_replace_demo

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio added the OOBE 📦✨ Out-of-box experience label Aug 9, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 9, 2022
@AzulRadio AzulRadio removed the 🏰 citadel Ignition Citadel label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #461 (ca7acf5) into ign-gui3 (8bc5bed) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           ign-gui3     #461   +/-   ##
=========================================
  Coverage     69.81%   69.81%           
=========================================
  Files            29       29           
  Lines          3273     3273           
=========================================
  Hits           2285     2285           
  Misses          988      988           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina chapulina added the 🏰 citadel Ignition Citadel label Aug 10, 2022
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the IgnHelpers.getDecimals:

// Get number of decimal digits based on a widget's width
// TODO(chapulina) Move this to a common place so all widgets can use it
function getDecimals(_width) {
if (_width <= 80)
return 2;
else if (_width <= 100)
return 4;
return 6;
}

src/plugins/grid_3d/Grid3D.qml Outdated Show resolved Hide resolved
src/plugins/grid_3d/Grid3D.qml Outdated Show resolved Hide resolved
Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio merged commit db2ab81 into ign-gui3 Aug 16, 2022
@AzulRadio AzulRadio deleted the azulradio/grid3d_gzpose branch August 16, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants