Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add degree as an optional unit for rotation in GzPose #475

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

AzulRadio
Copy link
Contributor

Signed-off-by: youhy haoyuan2019@outlook.com

New feature

Summary

Add degree as an optional unit for rotation in GzPose. Radian is set to default.

Test it

Can be tested with gazebosim/gz-sim#1642

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio added the OOBE 📦✨ Out-of-box experience label Aug 17, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #475 (c3754d0) into ign-gui3 (c3df98d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           ign-gui3     #475   +/-   ##
=========================================
  Coverage     69.81%   69.81%           
=========================================
  Files            29       29           
  Lines          3273     3273           
=========================================
  Hits           2285     2285           
  Misses          988      988           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment

include/ignition/gui/qml/GzPose.qml Outdated Show resolved Hide resolved
Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio merged commit d27c387 into ign-gui3 Aug 18, 2022
@AzulRadio AzulRadio deleted the azulradio/gzpose_degree branch August 18, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants