Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reset button position #505

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Change reset button position #505

merged 1 commit into from
Dec 5, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Nov 21, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🦟 Bug fix

Adjust the order the reset button so that it falls after the step button. Requires gazebosim/gz-sim#1805

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #505 (af5ea58) into gz-gui7 (780cb23) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           gz-gui7     #505   +/-   ##
========================================
  Coverage    69.03%   69.03%           
========================================
  Files           44       44           
  Lines         4831     4831           
========================================
  Hits          3335     3335           
  Misses        1496     1496           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jennuine jennuine added the needs upstream release Blocked by a release of an upstream library label Nov 22, 2022
@jennuine
Copy link
Contributor

Side note, users will need to remove their ~/.gz/sim/7/gui.config file

@ahcorde ahcorde enabled auto-merge (squash) November 22, 2022 09:01
@ahcorde
Copy link
Contributor

ahcorde commented Nov 22, 2022

@osrf-jenkins run tests please!

@nkoenig nkoenig merged commit 127dfaa into gz-gui7 Dec 5, 2022
@nkoenig nkoenig deleted the reorder-reset branch December 5, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants