Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixed width from world control #1805

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Remove fixed width from world control #1805

merged 1 commit into from
Nov 22, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Nov 21, 2022

Signed-off-by: Nate Koenig nate@openrobotics.org

🦟 Bug fix

The world control widget used a fix width, set via the gui.config file. This prevents the world control widget from scaling based on the content of the widget.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 21, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1805 (2b7a9bf) into gz-sim7 (4fa1f26) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           gz-sim7    #1805   +/-   ##
========================================
  Coverage    64.37%   64.37%           
========================================
  Files          341      341           
  Lines        27132    27132           
========================================
  Hits         17467    17467           
  Misses        9665     9665           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit 3d94c0b into gz-sim7 Nov 22, 2022
@ahcorde ahcorde deleted the world-control-width branch November 22, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants