-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color palette to plugin settings to change background color #62
Conversation
Signed-off-by: Sarathkrishnan Ramesh <sarathkrishnan99@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! This works for me!
It would be great if the color would persist when the configuration is saved. For example:
- Open
ign gui
- Add
Publisher
plugin - Change its background color to blue
- On the left menu,
Save configuration as
- Then
Load configuration
and choose the saved file - you'll see that the background goes back to white.
If you inspect the saved file, you'll see that it doesn't have any variables holding the color. I think we'll need to add it as a property of IgnCard
.
The plugin_params.config example should also be helpful to look at.
Okay! Thanks. I'll look into it. |
* Save plugin background color information in config file * Change default background color to white Signed-off-by: Sarathkrishnan Ramesh <sarathkrishnan99@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge once the default color is transparent.
Signed-off-by: Sarathkrishnan Ramesh <sarathkrishnan99@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for iterating!
* Add color palette to plugin settings to change background color * Save plugin background color information in config file Signed-off-by: Sarathkrishnan Ramesh <sarathkrishnan99@gmail.com>
Signed-off-by: Sarathkrishnan Ramesh sarathkrishnan99@gmail.com
Reference to issue #61
Description
Add color palette to select background color and transparency to the plugin settings. User can change the background in both docked and undocked state.
Basic Info
Tested on: Ubuntu 18.04