Fix TPE poseDirty getter

[luca-della-vedova]

Classic = vs == typo that wasn't caught at compile time because of the pimpl's raw pointer not enforcing const correctness.
It disabled the optimization that skipped updating the AABB tree for entities that didn't move, so the PR should help improve performance.

[mxgrey]

I think it's worth mentioning that there's no use for PIMPL in an ignition-physics physics engine plugin anyway.

We already get an API+ABI firewall for this library by loading it using ignition-plugin, so PIMPL doesn't accomplish anything.

[iche033]

I think we did pimpl at the beginning because there was an idea that the TPE library (in tpe/lib) would live outside of ign-physics or could be migrated later if needed. But that's no longer the case as we're now committing to having the library inside ign-phyics so we could just stop using pimpl in future classes

[iche033]

bad mistake, thanks for catching this!

[chapulina]

there was an idea that the TPE library (in tpe/lib) would live outside of ign-physics or could be migrated later if needed. But that's no longer the case as we're now committing to having the library inside ign-phyics

Is anything is TPE so specific to Ignition Physics that it couldn't be used on its own?

[iche033]

Is anything is TPE so specific to Ignition Physics that it couldn't be used on its own?

nope, TPE is not specific to ign-physics. It's designed to be a standalone library.

[scpeters]

fix for homebrew CI problems in gazebo-tooling/release-tools#366

[chapulina]

I took the liberty of addressing the codechecker warning on a4faa4b so we don't need a new PR, then a merge into this PR, etc.

LGTM with happy CI.

[codecov]

Codecov Report

Merging #182 (a4faa4b) into ign-physics2 (3f5a8a1) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           ign-physics2     #182   +/-   ##
=============================================
  Coverage         83.10%   83.10%           
=============================================
  Files               106      106           
  Lines              3983     3983           
=============================================
  Hits               3310     3310           
  Misses              673      673           

Impacted Files	Coverage Δ
dartsim/src/EntityManagementFeatures.cc	73.41% <ø> (ø)
tpe/lib/src/Entity.cc	86.50% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5a8a1...a4faa4b. Read the comment docs.