Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Shared Lib Migration : gz-physics #356

Merged
merged 5 commits into from
Jul 1, 2022
Merged

ign -> gz Shared Lib Migration : gz-physics #356

merged 5 commits into from
Jul 1, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jun 14, 2022
Closed
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #356 (025d855) into main (fac0793) will not change coverage.
The diff coverage is n/a.

❗ Current head 025d855 differs from pull request most recent head bdbd669. Consider uploading reports for the commit bdbd669 to get more accurate results

@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         128      128           
  Lines        5628     5628           
=======================================
  Hits         4196     4196           
  Misses       1432     1432
Impacted Files Coverage Δ
dartsim/src/SDFFeatures.cc 62.71% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac0793...bdbd669. Read the comment docs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 14, 2022
@chapulina chapulina changed the base branch from main to macro_migration June 15, 2022 16:19
Base automatically changed from macro_migration to main June 18, 2022 03:09
@methylDragon methylDragon force-pushed the shared_lib_migration branch 2 times, most recently from 7d09615 to d33cf6c Compare June 27, 2022 21:24
@methylDragon methylDragon marked this pull request as ready for review June 27, 2022 21:31
@methylDragon methylDragon force-pushed the shared_lib_migration branch 2 times, most recently from 3a765f8 to 1d8028c Compare June 27, 2022 22:19
chapulina
chapulina reviewed Jun 29, 2022
View reviewed changes
Migration.md Outdated Show resolved Hide resolved
@methylDragon
Migrate shared lib references
e04e410 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate SDF params
dd28a29 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add migration notes for shared libraries
6ea659a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Update kExpressedIn -> expressedIn
9b3f657 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Update migration notes
bdbd669 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@chapulina chapulina mentioned this pull request Jul 1, 2022
Merged
@chapulina chapulina merged commit adb8ac7 into main Jul 1, 2022
@chapulina chapulina deleted the shared_lib_migration branch July 1, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

@chapulina chapulina chapulina approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @scpeters @chapulina