Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting solver iterations #609

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Support setting solver iterations #609

merged 4 commits into from
Mar 21, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 19, 2024

🎉 New feature

Summary

Extends Solver feature to support setting solver iterations per step.

Added support in:

  • dart: only applicable if solver type is PgsBoxedLcpSolver
  • bullet-featherstone: sets solver iteration for btMultiBodyMCLPConstraintSolver. By default it's now set to 50 (same as the default value in //world/physics/bullet/solver/iters). Originally it was only 10. Changing to 50 improves stability and prevents objects from drifting.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Mar 19, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 78.40%. Comparing base (492b124) to head (adc1b3d).

Files Patch % Lines
dartsim/src/WorldFeatures.cc 83.78% 6 Missing ⚠️
bullet-featherstone/src/WorldFeatures.cc 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   78.32%   78.40%   +0.08%     
==========================================
  Files         140      140              
  Lines        8069     8132      +63     
==========================================
+ Hits         6320     6376      +56     
- Misses       1749     1756       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bullet-featherstone/src/WorldFeatures.cc Show resolved Hide resolved
bullet-featherstone/src/WorldFeatures.hh Show resolved Hide resolved
dartsim/src/WorldFeatures.cc Show resolved Hide resolved
dartsim/src/WorldFeatures.hh Show resolved Hide resolved
include/gz/physics/World.hh Show resolved Hide resolved
include/gz/physics/World.hh Outdated Show resolved Hide resolved
include/gz/physics/detail/World.hh Show resolved Hide resolved
test/common_test/world_features.cc Outdated Show resolved Hide resolved
test/common_test/world_features.cc Show resolved Hide resolved
test/common_test/world_features.cc Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 merged commit 69a11b4 into main Mar 21, 2024
8 checks passed
@iche033 iche033 deleted the solver_iters branch March 21, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants