Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overloaded virtual warnings on noble #1036

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 13, 2024

🦟 Bug fix

Summary

These warnings are disabled in #995 for harmonic on noble because fixes would involve ABI breaking changes. These warnings are useful and may help to uncover non-trivial errors. This PR removes most of the changes in #995 and fixes the warnings.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 13, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.67%. Comparing base (e187f52) to head (431d6dd).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
- Coverage   75.68%   75.67%   -0.01%     
==========================================
  Files         177      177              
  Lines       16959    16956       -3     
==========================================
- Hits        12835    12832       -3     
  Misses       4124     4124              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit 784db39 into main Aug 15, 2024
7 of 11 checks passed
@iche033 iche033 deleted the overload_warnings_noble branch August 15, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants