Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 24.04 CI, require cmake 3.22.1 #1037

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Enable 24.04 CI, require cmake 3.22.1 #1037

merged 8 commits into from
Aug 14, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Part of gazebosim/gz-cmake#350.

Summary

This adds a GitHub workflow using Noble and increases our minimum required cmake version to 3.22.1 since we are already requiring that in gz-cmake4. I removed one bit of logic for outdated cmake versions in 4925c87.

It also fixes the push branch regex to support multi-digit versions (copied from gazebosim/sdformat#1445) and fixes the CI badges in the README.

Test it

Check CI results

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Part of gazebosim/gz-cmake#350.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Fix push branch regex to support multi-digit versions.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

Doxygen check failed on noble:

  ++ curl -s https://raw.githubusercontent.com/gazebosim/gz-cmake/main/tools/doc_check.sh
  Error. The following warnings were found in gz-doxygen.warn.
  warning: source '/github/workspace/build/libgz-rendering-ogre.so' is not a readable file or directory... skipping.
  warning: source '/github/workspace/build/libgz-rendering-ogre.so' is not a readable file or directory... skipping.
  /github/workspace/tutorials/03_rendering_plugins.md:12: warning: Unexpected paragraph command found inside subsection!

moving it back to jammy

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

INTEGRATION_load_unload_ogre_gl3plus fails in Noble CI for both Jenkins and GitHub actions

@scpeters scpeters marked this pull request as ready for review August 14, 2024 05:10
@scpeters scpeters requested a review from iche033 as a code owner August 14, 2024 05:10
@scpeters
Copy link
Member Author

scpeters commented Aug 14, 2024

INTEGRATION_load_unload_ogre_gl3plus fails in Noble CI for both Jenkins and GitHub actions

while reading the console output, I noticed that we don't have ogre-next installed in Noble CI, so I've tried to enable that in 002d504

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

INTEGRATION_load_unload_ogre_gl3plus fails in Noble CI for both Jenkins and GitHub actions

while reading the console output, I noticed that we don't have ogre-next installed in Noble CI, so I've tried to enable that in 002d504

I can revert that if we want to address it separately

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor

iche033 commented Aug 14, 2024

The tests are failing with undefined symbol issue. I've updated to use the libogre-next-2.3-dev to see if it makes a difference. libogre-next-2.3-dev is version 2.3.1, while libogre-next-dev is 2.3.3

@iche033
Copy link
Contributor

iche033 commented Aug 14, 2024

The tests are failing with undefined symbol issue. I've updated to use the libogre-next-2.3-dev to see if it makes a difference. libogre-next-2.3-dev is version 2.3.1, while libogre-next-dev is 2.3.3

ogre2 tests should all pass now. There should only be one ogre1 test failing and there's a workaround in #1033

@iche033
Copy link
Contributor

iche033 commented Aug 14, 2024

I'll look into the ogre-next 2.3.3 issue separately

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

there are some new gcc warnings, and I'm not sure how to fix them; I'll merge after CI finishes if I don't see any suggestions to resolve them

@iche033
Copy link
Contributor

iche033 commented Aug 14, 2024

there are some new gcc warnings, and I'm not sure how to fix them; I'll merge after CI finishes if I don't see any suggestions to resolve them

the compile warnings should be fixed in #1036

@iche033
Copy link
Contributor

iche033 commented Aug 14, 2024

I'll look into the ogre-next 2.3.3 issue separately

looks like @j-rivero already reported the issue with the noble's ogre 2.3 debs: https://bugs.launchpad.net/ubuntu/+source/ogre-next/+bug/2063359. So gz-sim / gz-rendering wont work with libogre-next-dev from Ubuntu Noble and instead users have to use lbogre-next-2.3-dev from the osrf repo.

@scpeters scpeters merged commit 61403c5 into main Aug 14, 2024
6 of 9 checks passed
@scpeters scpeters deleted the scpeters/ionic_cmake branch August 14, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants