Include MoveTo Helper class to ign-rendering

[ahcorde]

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of the consolidation of Scene3D with ign-gazebo's GzScene3D gazebosim/gz-gui#137

Summary

This class is inside the ign-gazebo plugin which contains a TODO to move this hidden class to ign-rendering.

Test it

Checklist

• Signed all commits for DCO
• Added tests
• codecheck passed (See contributing)
• All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge

[chapulina]

I like the idea of having this functionality inside ign-rendering. I'm not so sure about keeping it in a separate class though. I think it could be part of the camera API, together with all the Track and Follow functions:

https://github.com/ignitionrobotics/ign-rendering/blob/07c4ca96c924db4004ccab9e0b7a1e6ac5b1b033/include/ignition/rendering/Camera.hh#L196-L273

What do you think, @iche033 ?

[iche033]

that was the intention before - putting it somewhere like in BaseCamera class. There is also an advantage of keeping this functionality in a separate class though. We can pimpl'ize it to avoid all the ABI compatibility headaches that we are facing with ign-rendering when making changes to templated classes in header files.

[chapulina]

There is also an advantage of keeping this functionality in a separate class though.

Yeah that's true, the current implementation could be added to ign-rendering3 even 👍

[ahcorde]

Added pimpl and retargeted to ign-rendering3

[iche033]

@osrf-jenkins run tests please

[mjcarroll]

Some small style updates

[iche033]

looks good to me.

[chapulina]

Should we add some tests?

[ahcorde]

@iche033 do you mind to have a look to the new tests? 8e98a13

[codecov]

Codecov Report

Merging #311 (f111938) into ign-rendering3 (d3eb5ca) will increase coverage by 0.26%.
The diff coverage is 90.58%.

@@                Coverage Diff                 @@
##           ign-rendering3     #311      +/-   ##
==================================================
+ Coverage           52.94%   53.21%   +0.26%     
==================================================
  Files                 129      131       +2     
  Lines               11917    12002      +85     
==================================================
+ Hits                 6310     6387      +77     
- Misses               5607     5615       +8     

Impacted Files	Coverage Δ
src/MoveToHelper.cc	90.47% <90.47%> (ø)
include/ignition/rendering/MoveToHelper.hh	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3eb5ca...f111938. Read the comment docs.

[iche033]

Just very small nitpicks. This is good to go as is