Testing Windows fix #392
Testing Windows fix #392
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
=======================================
Coverage 72.34% 72.34%
=======================================
Files 37 37
Lines 5052 5052
=======================================
Hits 3655 3655
Misses 1397 1397
|
Signed-off-by: Ian Chen <ichen@openrobotics.org>
src/CameraSensorUtil.hh
Outdated
| double _intrinsicsCx, double _intrinsicsCy, | ||
| double _intrinsicsS, double _clipNear, | ||
| double _clipFar); | ||
| math::Matrix4d GZ_SENSORS_VISIBLE buildProjectionMatrix( |
There was a problem hiding this comment.
I think it would be better to compile CameraSensorUtil.cc with each of the components that need it rather than making it visible here since it now becomes part of our public ABI.
Edit: Technically, I think it is visible by default on linux, so it is part of the public ABI (unfortunately) already, but when gazebosim/gz-cmake#166 is resolved, this would break in Linux as well.
There was a problem hiding this comment.
testing alternative fix in d5b64ef
There was a problem hiding this comment.
Windows CI looks good with the new changes.
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
🦟 Bug fix
Summary
Update:
Updated CMake to build camera related sensor components with the CameraSensorUtil.cc src file.
AddedGZ_SENSORS_VISIBLEto fix the windows build issue described in #391 (comment).TheCameraSensorUtil.hhheader file is in thesrcdirectory so we're not actually installing that header or exposing the functions. Happy to try an alternative solution if there's a better one.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.