3 ➡️ 5 #1315
Merged
3 ➡️ 5 #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
…el retarget) (#1314) In the event a user enters the wrong name for a certain joint, the JointPositionController system will silently fail. This PR adds a simple error message that tells the user that the joint was not found. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
chapulina
force-pushed
the
chapulina/3_to_5
branch
from
69b2745
to
37a3a46
Compare
iche033
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-gazebo3toign-gazebo5Branch comparison: ign-gazebo5...ign-gazebo3
ign-gazebo3toign-gazebo5because lots of the threading have changed. Rather than trying to fix it in this PR, I've kept the static "done" checks there and left a note to open a PR specific toign-gazebo5later. That's tracked in Cleanup GUI plugin menu #1254Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)