Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore GUI support for macOS #1813

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

srmainwaring
Copy link
Contributor

@srmainwaring srmainwaring commented Nov 24, 2022

🦟 Bug fix

Fixes #1812

Summary

Restore the change to src/cmd/cmdsim.rb.in from #1225 that allows macOS to run the GUI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 24, 2022
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #1813 (3db57c9) into gz-sim7 (bb85aa2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           gz-sim7    #1813   +/-   ##
========================================
  Coverage    64.42%   64.42%           
========================================
  Files          341      341           
  Lines        27151    27151           
========================================
  Hits         17492    17492           
  Misses        9659     9659           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit 4cce6fe into gazebosim:gz-sim7 Nov 24, 2022
@srmainwaring srmainwaring deleted the srmainwaring/fix-1812 branch November 24, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

macOS gui support broken by #1768
2 participants