-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update added-mass of lrauv model and remove added mass definitions from examples #2608
Open
arjo129
wants to merge
8
commits into
gz-sim9
Choose a base branch
from
arjo/fix/update_model
base: gz-sim9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 9, 2024
-
Update added-mass of lrauv model and remove added mass definitions from
examples Fixes #2575 Since, we have decided to deprecate added mass in the hydrodynamics plugin in favour of Rigid Bodies, we should update our examples to avoid the warning. TODO: Update maritime tutorials and migration guide. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Configuration menu - View commit details
-
Copy full SHA for daaf518 - Browse repository at this point
Copy the full SHA daaf518View commit details -
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Configuration menu - View commit details
-
Copy full SHA for e5d2b7d - Browse repository at this point
Copy the full SHA e5d2b7dView commit details
Commits on Sep 11, 2024
-
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Configuration menu - View commit details
-
Copy full SHA for 6e00f71 - Browse repository at this point
Copy the full SHA 6e00f71View commit details
Commits on Sep 13, 2024
-
I'm reverting DVL tests as they never considered added mass. Adding added mass changes the expected velocities. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Configuration menu - View commit details
-
Copy full SHA for 0998be2 - Browse repository at this point
Copy the full SHA 0998be2View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fc7a7ff - Browse repository at this point
Copy the full SHA fc7a7ffView commit details
Commits on Sep 20, 2024
-
Move model to Open Robotics ownership
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Configuration menu - View commit details
-
Copy full SHA for 23f589f - Browse repository at this point
Copy the full SHA 23f589fView commit details -
Merge branch 'arjo/fix/update_model' of https://github.com/gazebosim/…
…gz-sim into arjo/fix/update_model
Configuration menu - View commit details
-
Copy full SHA for 229afb2 - Browse repository at this point
Copy the full SHA 229afb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6775fde - Browse repository at this point
Copy the full SHA 6775fdeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.