Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes from Dome tutorial party #187

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Changes from Dome tutorial party #187

merged 4 commits into from
Sep 30, 2020

Conversation

j-rivero
Copy link
Contributor

  • Use https for key download 57f47a8
  • Update versions to modern ones 8b5ac8d
  • Remove first person from instructions 4945d0d
  • Update Windows: dependencies, Visual Studio and Windows versions 08c1df6

@j-rivero
Use https for key download
57f47a8 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Update versions to modern ones
8b5ac8d 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Remove first person from instructions
4945d0d 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Update Windows: dependencies, Visual Studio and Windows versions.
08c1df6 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files          47       47           
  Lines        4484     4484           
=======================================
  Hits         3989     3989           
  Misses        495      495

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 546a4c4...08c1df6. Read the comment docs.

chapulina
chapulina approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try the Windows changes but everything looks reasonable to me 👍

@chapulina chapulina merged commit 1b3a3e0 into master Sep 30, 2020
@chapulina chapulina deleted the review_dome_install branch September 30, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @chapulina