Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table in "Nodes and topics tutorial" #356

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Sep 9, 2022

🦟 Bug fix

Summary

The tutorial "Nodes and Topics" uses two tables to show legal/ilegal topics and namespaces. The empty topics and namespaces are rendered as </td>. I'm trying this fix but not 100% sure if this will fix it.

Tagging @nkoenig in case he has extra tips.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #356 (48a3608) into gz-transport12 (a31c20f) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           gz-transport12     #356   +/-   ##
===============================================
  Coverage           88.11%   88.11%           
===============================================
  Files                  52       52           
  Lines                4848     4848           
===============================================
  Hits                 4272     4272           
  Misses                576      576           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sign commit

@caguero caguero merged commit 042102f into gz-transport12 Sep 12, 2022
@caguero caguero deleted the tutorial_nodes_topics branch September 12, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants