Add breaks to AddOptionalAccessCondition in PipelineHelper #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Builder resultBuilder = PipelineHelpers.addOptionalSourceAccessContitionHeader(builder, accessCondition); | ||
|
|
||
| // Assert | ||
| assertNotNull(resultBuilder); |
There was a problem hiding this comment.
Can you assert the internal value of the access condition?
There was a problem hiding this comment.
no, we cannot. In java, those private properties are not exposed.
There was a problem hiding this comment.
I'd expect that because it is a test in the pipeline, you could add another test wrapper to the pipeline in your test to inspect the headings that were added.
There was a problem hiding this comment.
I thought about that, but it seems it is hard to construct a mock object this way because WebResource.Builder is finalized, as a result, we cannot extend a mock class from the Builder...
added 2 commits
July 30, 2012 15:57
PipelineHelper/addOptionalSourceAccessConditionHeader
…to Beirut Conflicts: microsoft-azure-api/src/main/java/com/microsoft/windowsazure/services/blob/implementation/BlobRestProxy.java
gcheng
pushed a commit
that referenced
this pull request
Jul 30, 2012
Add breaks to AddOptionalAccessCondition in PipelineHelper
gcheng
pushed a commit
that referenced
this pull request
Aug 2, 2012
Tables implementation work by rpaquay
gcheng
pushed a commit
that referenced
this pull request
Jan 25, 2013
Synchronize the AssetCRUD branch with the dev branch.
gcheng
pushed a commit
that referenced
this pull request
Jan 25, 2013
gcheng
pushed a commit
that referenced
this pull request
Feb 8, 2013
Adding javadocs for missing parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure#85