Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KomodoCore v0.5.8 Integrations #18

Merged
merged 16 commits into from
Mar 4, 2022
Merged

KomodoCore v0.5.8 Integrations #18

merged 16 commits into from
Mar 4, 2022

Conversation

parseccentric
Copy link
Contributor

@parseccentric parseccentric commented Mar 2, 2022

What's new?

  • Release/v0.5.8 komodo-unity#101

  • Added a small green sphere to the origin of the hand so it's more obvious when you're large where to align your hand with an object.

  • Physical floor and ceiling were bumped down by 2 meters so that people don't have to go through the height calibration process.

@parseccentric
Copy link
Contributor Author

parseccentric commented Mar 2, 2022

Initial Test: https://uofi.box.com/s/pl8icy6kkyrr1jf5ob4a2xuul6gte03t

Fix:
Instructor menu wouldn't open: OnClick handler needed to be removed from the button script. This needed to be applied to the prefab.
I think the TextMeshPro needed to be imported, too.

@parseccentric
Copy link
Contributor Author

Added a small green sphere to the origin of the hand so it's more obvious when you're large where to align your hand with an object. This was necessary because in KomodoControllerInteraction.cs, you can see that the sphere collision radius for the hand is fixed at 0.1f. Unfortunately, that means that when you're large, you have a comparatively small place to put your hand. The sphere does not stay at 0.1f, but instead has a radius of 0.005f, in order that the user can be more accurate than necessary at smaller scales and as accurate as necessary at larger scales.

@parseccentric
Copy link
Contributor Author

Physical floor was bumped down by 2 meters because height calibration doesn't work without a terrain. And height adjustment was not fixing the problem. This may make the floor look too far below the player, but hopefully it is better than before.

@parseccentric
Copy link
Contributor Author

parseccentric commented Mar 2, 2022

Tested the three above improvements (ba7788f) and these issues seem to be resolved. https://uofi.box.com/s/b6z3ck2lfdabmmrbqf1q98mg50b517nx

@Barasakar
Copy link
Contributor

@parseccentric
Copy link
Contributor Author

Note: we accidentally refreshed the page (or in my case, closed the tab) before saving the logs.

@parseccentric
Copy link
Contributor Author

Box > Komodo > Internal > Archive > Builds > impress-v0.1.3-ba7788f-2022-03-02-1506

  • Chrome logs
  • Firefox logs
  • build test results
  • build info
  • capture files

@parseccentric parseccentric merged commit 831b036 into main Mar 4, 2022
@parseccentric parseccentric mentioned this pull request Mar 4, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants