Release/v0.5.8 #101

parseccentric · 2022-02-08T22:33:57Z

v0.5.8 Release: Interactable Drawings, Refactored DrawingInstanceManager

Interactable Drawings

Please see #100

Refactoring

Renamed Draw_Refresh to ReceiveDrawUpdate and refactored into the following functions:

ContinueLine
EndLine
DeleteLine
HideLine
ShowLine

Combined lineRenderersInQueue and allStrokeIDValidator into a single dictionary, lineRendererFromID, and made sure any uses of that dictionary went through new functions that talk directly to the ID. Did not change the overall functionality.

De-coupled DrawingInstanceManager from NetworkObjectsManager.

Added various warnings for edge cases, like trying to move a line that exists in your client but not in someone else's (because you drew it before they joined).

The motivation is that we should now be able to more easily debug the content. In particular, we can address the warning in the linked pull request and display the drawing line / stroke ID.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Testing
Change that requires a documentation update

How Has This Been Tested?

Test basic single-client transforming of drawings

Connect with a client, then...
make drawings
try to transform your own drawings (translate / rotate / scale)

Test basic synchronized transforming of drawings

Connect with two clients, then...
make drawings
try to transform your own drawings (translate / rotate / scale)
- expected result: transform synchronizes correctly
try to transform each others' drawings (translate / rotate / scale)
- expected result: transform is successful
- expected result: transform synchronizes correctly

Note that undo only applies to the draw action and erase action, and not to any transform actions.

Manual Test
Unit Test
Integration / End-to-End Test

[Duplicate all of the above for each distinct feature / bug fix / etc.]

Test Configuration

Firefox
Oculus Quest 1
Oculus Quest 2

PC VR (Link / AirLink)
Standalone

Checklist:

Modified from this article:
Phillip Johnston, “A GitHub Pull Request Template for Your Projects - Embedded Artistry,” Embedded Artistry, Aug. 04, 2017. https://embeddedartistry.com/blog/2017/08/04/a-github-pull-request-template-for-your-projects/ (accessed Jul. 22, 2021).

…le-drawings Interactable Drawings

This reverts commit 34862ed.

parseccentric · 2022-02-08T22:48:13Z

Komodo/Assets/Packages/KomodoCore/Runtime/Scripts/RuntimeSession/Managers/EraseManager.cs

+                {
+                    UndoRedoManager.Instance.savedStrokeActions.Push
+                    (
+                        (System.Action)


(Future) Do we need the System.Action wrapper?

parseccentric · 2022-02-09T00:16:57Z

Add manual and semi-automated tests for various drawing functions
Put new manual tests onto this branch
Test dev build
Test non-dev build
Upload build with any attached logs

parseccentric · 2022-02-10T01:10:14Z

See https://uofi.box.com/s/4d4nbx1l98ipoe41ko7m23kcsa36fg9g for the capture log, the build test results, additional bug and workaround notes, etc.

parseccentric · 2022-02-10T01:11:35Z

VR Notes:

avatar only seems to disappear from own client when tab is closed -- not from other clients. Need to verify further.
after exiting VR mode and going to spectator mode, avatar goes to the ground
after pressing leave and rejoin, some avatar positions get copied to non-connected users's avatars (their head and hands are in the same place)

Spectator Notes:

CAUTION: IF YOU EVER ENTER VR AND EXIT VR, YOU WILL LOSE ACCESS TO THE INSTRUCTOR MENU BUTTON. Workaround: refresh the page.
Known issue: if you ever refresh the page, the capture will appear to not be running.
- If you intend to stop the capture, press start capture (which will try to start the capture but be ignored), then press stop capture (which will successfully stop the capture)
- If you intend to let the capture continue, it's best to not press anything.

WORKAROUND: it is paramount to check the status of the session connection in the people tab before pressing Start Capture. IT CANNOT say […] <session id>. If it does, then your capture will fail to start. If it does have the ellipses, you must refresh the page, Leave and Rejoin, or Close Connection and Rejoin until the ellipses goes away.

VR Bug: Drawing messages aren't always received after reconnection

Steps to reproduce:

J joined
B joined
J turned off wifi and turned back on
B refreshed (multiple times)
B entered VR and exited VR (multiple times)
B started capture
B could see J moving and drawing
J could see B moving
J could not see B drawing
B's people tab said [...] <session ID>
B left and rejoined
same results
B closed connection and rejoined
same results
J left and rejoined
same results
J closed connection and rejoined
J could see B drawing

parseccentric · 2022-02-25T19:51:59Z

Please see commits in #99 to understand some bug fixes finished in release/v0.5.7.

parseccentric · 2022-02-25T21:20:30Z

komodo-unity-v0.5.8-rcUnknown-2022-02-25-1518-parseccentric.log

Barasakar · 2022-02-25T21:20:40Z

v0.5.8-Jonathan-Chrome.log

parseccentric · 2022-02-25T21:23:00Z

komodo-relay-2022-02-25-1522.log

parseccentric · 2022-02-25T21:32:00Z

Finish writing build test results and upload them
Upload capture files and annotate them
Create non-development build
Upload non-dev build to base/v0.5.8 and change relay URLs
Upload non-dev build to base/stable and change relay URLs
Update test template
Then merge!
Create tag and write release (to OpenUPM)
Upload public non-dev build to Box and to release (with localhost relay URLs)

parseccentric · 2022-02-25T21:37:39Z

test-results-2022-02-25-1443.md

parseccentric · 2022-02-25T22:46:13Z

@Barasakar I'm just going to bypass our typical review process and merge this myself. Please let me know if you find anything wrong in the repo, and we can recuperate from there.

parseccentric · 2022-02-25T22:53:06Z

Finish writing build test results and upload them

Upload capture files and annotate them

Create non-development build

Upload non-dev build to base/v0.5.8 and change relay URLs

Upload non-dev build to base/stable and change relay URLs

Update test template
Then merge!

Create tag and write release (to OpenUPM)

Upload public non-dev build to Box and to release (with localhost relay URLs)

@Barasakar This is everything I do after each testing session. It's kind of a lot TBH so if you find a way to simplify that then go right ahead!

parseccentric and others added 13 commits February 7, 2022 13:41

Merge branch 'main' into dev

8dde0f8

Re-enabled grabbable drawing feature

41b6fc3

added comments for where to find relay vars

6c47315

fixed whitespace, removed stale comments and regions

4266589

Merge pull request #100 from gelic-idealab/feature/brandon/interactab…

048603d

…le-drawings Interactable Drawings

add handlers for applying look and look end interactions

1d4f286

moved enums and structs into own files

a681d89

added comment about hand rotation

e6c2129

remove unused code

aea5ae9

refactored into functions; renamed variables; adjusted whitespace

2b46a60

renaming

4dc9c83

moved draw action types out of entity type

34862ed

Revert "moved draw action types out of entity type"

1a9f379

This reverts commit 34862ed.

parseccentric commented Feb 8, 2022

View reviewed changes

parseccentric added 3 commits February 9, 2022 19:18

updated test results to match new features

eaec38f

add comments explaining draw system

49fd14a

Merge branch 'main' into release/v0.5.8 (from release/v0.5.7)

6daf602

parseccentric added 2 commits February 25, 2022 16:17

version number

2286d89

update test template

c71188b

parseccentric merged commit 5ee54e5 into main Feb 25, 2022

parseccentric deleted the release/v0.5.8 branch February 25, 2022 23:03

parseccentric mentioned this pull request Mar 4, 2022

KomodoCore v0.5.8 Integrations gelic-idealab/impress#18

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/v0.5.8 #101

Release/v0.5.8 #101

parseccentric commented Feb 8, 2022 •

edited

Loading

parseccentric Feb 8, 2022

parseccentric commented Feb 9, 2022 •

edited

Loading

parseccentric commented Feb 10, 2022

parseccentric commented Feb 10, 2022 •

edited

Loading

parseccentric commented Feb 25, 2022

parseccentric commented Feb 25, 2022

Barasakar commented Feb 25, 2022

parseccentric commented Feb 25, 2022

parseccentric commented Feb 25, 2022 •

edited

Loading

parseccentric commented Feb 25, 2022 •

edited

Loading

parseccentric commented Feb 25, 2022

parseccentric commented Feb 25, 2022

Release/v0.5.8 #101

Release/v0.5.8 #101

Conversation

parseccentric commented Feb 8, 2022 • edited Loading

v0.5.8 Release: Interactable Drawings, Refactored DrawingInstanceManager

Interactable Drawings

Refactoring

Type of change

How Has This Been Tested?

Test Configuration

Checklist:

parseccentric Feb 8, 2022

Choose a reason for hiding this comment

parseccentric commented Feb 9, 2022 • edited Loading

parseccentric commented Feb 10, 2022

parseccentric commented Feb 10, 2022 • edited Loading

parseccentric commented Feb 25, 2022

parseccentric commented Feb 25, 2022

Barasakar commented Feb 25, 2022

parseccentric commented Feb 25, 2022

parseccentric commented Feb 25, 2022 • edited Loading

parseccentric commented Feb 25, 2022 • edited Loading

parseccentric commented Feb 25, 2022

parseccentric commented Feb 25, 2022

parseccentric commented Feb 8, 2022 •

edited

Loading

parseccentric commented Feb 9, 2022 •

edited

Loading

parseccentric commented Feb 10, 2022 •

edited

Loading

parseccentric commented Feb 25, 2022 •

edited

Loading

parseccentric commented Feb 25, 2022 •

edited

Loading