Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neuvillette Implementation #1727

Merged
merged 78 commits into from
Dec 10, 2023
Merged

Neuvillette Implementation #1727

merged 78 commits into from
Dec 10, 2023

Conversation

Charlie-Zheng
Copy link
Contributor

@Charlie-Zheng Charlie-Zheng commented Sep 28, 2023 •
edited by k0l11
Loading

  • New character package
  • Config in character package
  • Run pipeline with added config
  • Character key
  • Shortcuts for character key
  • Add Character package to imports
  • Character talent stats
  • Character curve
  • Normal Attack
  • Charge Attack / Aimed Shot
  • Skill
  • Burst
  • A1
  • A4
  • C0
  • C1
  • C2
  • C3
  • C4
  • C5
  • C6
  • Other necessary talents (custom dash/jump, low/high plunge, ...)
  • Hitlag
  • ICD
  • StrikeType
  • Hitboxes
  • Attack durability
  • Particles
  • Frames
  • Update documentation
  • Update localization (IngameNames.json)

@Charlie-Zheng Charlie-Zheng marked this pull request as ready for review October 3, 2023 15:58
@Charlie-Zheng
Copy link
Contributor Author

Need to add filter to A1 event subscription to only do enemy reactions

@Charlie-Zheng
Copy link
Contributor Author

Charlie-Zheng commented Oct 5, 2023 •
edited
Loading

Also Neuv c6 is very very scuffed because it cannot pick up any droplets that generate during the duration of Neuv CA (primarily from c4).

This is a system limitation since the action frames get cached immediately instead of being checked at CanQueueAfter. Additionally, if the CA extends beyond the CanQueueAfter time, the CA might extend again so multiples calls to calculate the action frames are required.

Is there a way to make like c6 Neuv give an error and prevent people from simming c6?

imring
imring reviewed Oct 20, 2023
View reviewed changes
internal/characters/neuvillette/asc.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/asc.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/neuvillette.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/charge.go Outdated Show resolved Hide resolved
internal/common/sourcewaterdroplet.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/skill.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/cons.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/cons.go Outdated Show resolved Hide resolved
internal/characters/traveler/common/hydro/travelerhydro.go Outdated Show resolved Hide resolved
ui/packages/docs/src/components/Fields/character_data.json Outdated Show resolved Hide resolved
@k0l11 k0l11 changed the title Neuvilette Implementation Neuvillette Implementation Dec 8, 2023
k0l11
k0l11 reviewed Dec 9, 2023
View reviewed changes
internal/characters/neuvillette/stats.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/stats.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/stats.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/stats.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/stats.go Outdated Show resolved Hide resolved
ui/packages/docs/src/components/AoE/character_data.json Outdated Show resolved Hide resolved
internal/characters/neuvillette/charge.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/cons.go Show resolved Hide resolved
internal/characters/neuvillette/charge.go Outdated Show resolved Hide resolved
internal/characters/neuvillette/charge.go Outdated Show resolved Hide resolved
@Charlie-Zheng
Initial commit of neuvilette
2118c43
@Charlie-Zheng
Fixed spiritbreath thorns using the main skill multipliers. Fixed Neu…
155d675 
…v A1 dmg bonus being calculated wrong
@Charlie-Zheng
Added note about the fast CA cancel
aac0f6f
@Charlie-Zheng
Fixed NA hitbox
4ff4d05
@Charlie-Zheng
Adjusted hitbox sizes and ICD
bbb9140
@Charlie-Zheng
Fix burst snapshot delay
927da11
@Charlie-Zheng
Changed Neuvillette E spiritbreath thorn to not be on hit
11a5618
@Charlie-Zheng
changed burst Sourcewater Droplet to spawn 3-2-1 on Q hits
c60bc09
@Charlie-Zheng
Added some TODOs to CA
be01466
@Charlie-Zheng
Added Neuv frames.CA drain frames still needed. CA hitmark frames nee…
59ba631 
…d double checking.Implemented choosing less than 8 ticks of CA to channel
@Charlie-Zheng
Added early cancel end lag
b5e1f51
@Charlie-Zheng
Fixed orb spawn
1d5b049
@Charlie-Zheng
fixed triggering C6 always triggering
514b859
@Charlie-Zheng
fixed Neuv A4
35bfd84
@Charlie-Zheng
Run pipeline, added docs, changed sourcewater droplet priority to ran…
03200e1 
…dom, added droplets field. Added log event for spawning droplets. Added errors when trying to early cancel with inappropriate ability
@Charlie-Zheng
added aoe data. fixed sourcewater droplet absorb range to 15
19dee42
@Charlie-Zheng
Differentiated HMC and Neuv sourcewater droplets for gadget limits.
8c828bf
@Charlie-Zheng
Fixed max ticks always giving error. Remove warning because it doesnt…
c8dd01c 
… run at the right time.
@Charlie-Zheng
Fixed character curve
bfcb017
@Charlie-Zheng
fixed bug with getting 3 random droplets
d64b2b3
@Charlie-Zheng
Fixed A1 key being wrong. Fixed Spiritbreath thorn being HP scaling i…
4acab4c 
…nstead of ATK scaling
@k0l11 k0l11 merged commit f761b8e into genshinsim:main Dec 10, 2023
2 of 3 checks passed
RarePossum pushed a commit to RarePossum/gcsim that referenced this pull request Dec 15, 2023
@Charlie-Zheng @imring @RarePossum
Neuvillette Implementation (genshinsim#1727)
e6b971d 
---------

Co-authored-by: imring <vitaliyvorobets25@gmail.com>
RarePossum pushed a commit to RarePossum/gcsim that referenced this pull request Dec 15, 2023
@Charlie-Zheng @imring @RarePossum
Neuvillette Implementation (genshinsim#1727)
75d7ada 
---------

Co-authored-by: imring <vitaliyvorobets25@gmail.com>
k0l11 pushed a commit that referenced this pull request Dec 24, 2023
@RarePossum @Charlie-Zheng @imring
Adding Navia (#1809)
0d1c4e9 
* Navia Initial Commit. Todo, fix SurgingBlade() and SkillCB() not being registered, and add skill buffs, and cons. Also fix Burst hitbox and targetting. Also Frames

* Fixed Stackoverflow from lack of Init, added CDs for Skill, along with DMG%, CR and CD buffs. Burst adjusted firerate and hitboxes

* Fixed All Burst hits granting Shrapnel
Shotgun Scaling (was divided by 5)
Core ordering
Minor Skill Stuff

* Added:
- Burst Status
- Conditionals

Fixed:
- Burst Targetting
- Burst Snapshot
- C2
- C4
- Particle Gen
- Skill ICDs

* Added:
- Basic Frames

Fixed:
- Skill AoE (still rudimentary)

* Fixed:
- Skill Array length

* Fixed:
- Character Curve

* Added:
- Nighttime Whispers of the Echoing Woods

TODO:
- Fix how the Crystallise Bonus works

* Fixed:
- Nighttime Whispers array error and converted to AttackMod instead of Stat mod

* Fixed:
- Burst and C2 Snapshotting
- C2 only working with Burst up
- Nighttime Whispers granting Damage% instead of Geo%
- Renamed nighttimewhispers.go

* Fixed:
- Nighttime Whispers' 2nd Buff
- Added comments

* Fixed:
- c4 Applying on skill instead of Burst

* Update for v2

* Update for v2

* Refactored some callbacks

* Neuvillette Implementation (#1727)

---------

Co-authored-by: imring <vitaliyvorobets25@gmail.com>

* Navia Initial Commit. Todo, fix SurgingBlade() and SkillCB() not being registered, and add skill buffs, and cons. Also fix Burst hitbox and targetting. Also Frames

* Reverted some things I missed when rebasing

* Fixed Keys

* Removed nighttimewhispers.go

* Fixed missing import, and infusion timing out

* Fixed shot calculation

* Fixed shot calculation again

* Correct Frames based on footage
Fixed Normal Attack Hitboxes
Fixed Burst Artillery Timings
Fixed Surging blade being a callback
Adjusted for New Crystallise mechanism

* Added N0 timings and removed incorrect import

* Fixed NA out of range error, and incorrect Skill hitboxes

* Cleaned up Pull Crystal Code Slightly

* Fixed Navia's Skill buffs not applying to her shotgun due to timeout

* Fixed NA starting during Hold Skill

* Fixed NA starting during Hold Skill

* Fixed comments, updated locale, ran pipeline, added documentation, fixed pruning hitbox for skill

* Fix linting, hopefully

* Fix linting again, hopefully

* third linting change

* addressed comments, updated grammar, fixed skill, icd, updated documentation

* fixed typos

---------

Co-authored-by: Charlie-Zheng <Charlie-Zheng@users.noreply.github.com>
Co-authored-by: imring <vitaliyvorobets25@gmail.com>
thom7195 pushed a commit to thom7195/gcsim that referenced this pull request Feb 19, 2024
@RarePossum @Charlie-Zheng
@imring @sukardit
Adding Navia (genshinsim#1809)
98ac5c7 
* Navia Initial Commit. Todo, fix SurgingBlade() and SkillCB() not being registered, and add skill buffs, and cons. Also fix Burst hitbox and targetting. Also Frames

* Fixed Stackoverflow from lack of Init, added CDs for Skill, along with DMG%, CR and CD buffs. Burst adjusted firerate and hitboxes

* Fixed All Burst hits granting Shrapnel
Shotgun Scaling (was divided by 5)
Core ordering
Minor Skill Stuff

* Added:
- Burst Status
- Conditionals

Fixed:
- Burst Targetting
- Burst Snapshot
- C2
- C4
- Particle Gen
- Skill ICDs

* Added:
- Basic Frames

Fixed:
- Skill AoE (still rudimentary)

* Fixed:
- Skill Array length

* Fixed:
- Character Curve

* Added:
- Nighttime Whispers of the Echoing Woods

TODO:
- Fix how the Crystallise Bonus works

* Fixed:
- Nighttime Whispers array error and converted to AttackMod instead of Stat mod

* Fixed:
- Burst and C2 Snapshotting
- C2 only working with Burst up
- Nighttime Whispers granting Damage% instead of Geo%
- Renamed nighttimewhispers.go

* Fixed:
- Nighttime Whispers' 2nd Buff
- Added comments

* Fixed:
- c4 Applying on skill instead of Burst

* Update for v2

* Update for v2

* Refactored some callbacks

* Neuvillette Implementation (genshinsim#1727)

---------

Co-authored-by: imring <vitaliyvorobets25@gmail.com>

* Navia Initial Commit. Todo, fix SurgingBlade() and SkillCB() not being registered, and add skill buffs, and cons. Also fix Burst hitbox and targetting. Also Frames

* Reverted some things I missed when rebasing

* Fixed Keys

* Removed nighttimewhispers.go

* Fixed missing import, and infusion timing out

* Fixed shot calculation

* Fixed shot calculation again

* Correct Frames based on footage
Fixed Normal Attack Hitboxes
Fixed Burst Artillery Timings
Fixed Surging blade being a callback
Adjusted for New Crystallise mechanism

* Added N0 timings and removed incorrect import

* Fixed NA out of range error, and incorrect Skill hitboxes

* Cleaned up Pull Crystal Code Slightly

* Fixed Navia's Skill buffs not applying to her shotgun due to timeout

* Fixed NA starting during Hold Skill

* Fixed NA starting during Hold Skill

* Fixed comments, updated locale, ran pipeline, added documentation, fixed pruning hitbox for skill

* Fix linting, hopefully

* Fix linting again, hopefully

* third linting change

* addressed comments, updated grammar, fixed skill, icd, updated documentation

* fixed typos

---------

Co-authored-by: Charlie-Zheng <Charlie-Zheng@users.noreply.github.com>
Co-authored-by: imring <vitaliyvorobets25@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kengzzzz kengzzzz kengzzzz left review comments

@imring imring imring left review comments

@k0l11 k0l11 k0l11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Charlie-Zheng @imring @kengzzzz @k0l11