Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 dev: fix warnings and update trading index #180

Merged
merged 2 commits into from
Jun 6, 2022
Merged

v4 dev: fix warnings and update trading index #180

merged 2 commits into from
Jun 6, 2022

Conversation

maread99
Copy link
Collaborator

@maread99 maread99 commented Jun 3, 2022

v4 development (#61).

  • Fixes warnings.
  • Updates ExchangeCalendar.trading_index and calendar_helpers._TradingIndex.

See commit messages for more further details.

Fixes warnings:
- pandas `union_many` deprecated.
- `pd.Series.append` deprecated.
- writting to a copy of an array (pandas).

Also:
- adds `indexes_union` function to `pandas_utils`.
- adds doctests in `pandas_utils` to test suite.
@maread99 maread99 added documentation Improvements or additions to documentation maintenance development labels Jun 3, 2022
Fixes bug that included close (wrongly) when `force` was True,
`intervals` was False and closed was `left` or `neither`. Revises test.

Revises so that `start` and `end` can be passed as either date or
minute. Adds `TestTradingIndex.test_start_end_times`.

Updates tutorial `trading_index.ipynb`.

Also:
- adds following functions to `calendar_helpers` and associated
test(s) to `test_calendar_helpers`:
  - `is_date`
  - `to_utc`
  - `parse_date_or_minute`
@maread99 maread99 merged commit 76ea41c into v4 Jun 6, 2022
@maread99 maread99 deleted the working-v4 branch June 6, 2022 12:01
@maread99 maread99 mentioned this pull request Jun 6, 2022
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development documentation Improvements or additions to documentation maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant