Migrate to new test base, 4 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates following test modules to new test base: - `test_xfra_calendar.py` - `test_xhel_calendar.py` - `test_xice_calendar.py` - `test_xidx_calendar.py` - `test_xist_calendar.py` - `test_xjse_calendar.py` - `test_xkar_calendar.py` - `test_xkls_calendar.py` - `test_xkrx_calendar.py` - `test_xlim_calendar.py` Also removes `xkrx_old.csv` from test resources.
Migrates following test modules to new test base: - `test_xmad_calendar.py` - `test_xmex_calendar.py` - `test_xmil_calendar.py` - `test_xmos_calendar.py` - `test_xnys_calendar.py` - `test_xnze_calendar.py` - `test_xosl_calendar.py` - `test_xphs_calendar.py` - `test_xpra_calendar.py` - `test_xses_calendar.py` Also removes `xkrx_old.csv` from test resources.
Migrates following test modules to new test base: - `test_xsgo_calendar.py` - `test_xshg_calendar.py` - `test_xsto_calendar.py` - `test_xswx_calendar.py` - `test_xtae_calendar.py` - `test_xtai_calendar.py` - `test_xtks_calendar.py` - `test_xtse_calendar.py` - `test_xwar_calendar.py` - `test_xwbo_calendar.py` Minor revision to `ExchangeCalendarTestBaseNew` tests: - `test_late_opens` - `test_early_closes`
This commit concludes migration to new test base. Removes classes made redundant by new test base: - `ExchangeCalendarTestBase` (previous test base) - `OpenDetectionTestCase` - `NoDSTExchangeCalendarTestBase` Renames `ExchangeCalendarTestBaseNew` as `ExchangeCalendarTestBase`.
Migrates following test classes to pytest: - `CalendarRegistrationTestCase` (renamed `TestCalendarRegistration`). - `DefaultsTestCase` (made function and renamed `test_default_calendars`). - `DaysAtTimeTestCase` (made function and renamed `test_days_at_time`). `parameterized` development requirement now redundant: - removes `parameterized` from extras_require of `setup.py`.
This was referenced Oct 8, 2021
Closed
Extends documentation for optionally implemented `ExchangeCalendarTestBase` fixtures.
|
This is great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR conludes the migration to the new test base.
test_exchange_calendar.pyto pytest.setup.py.Summary
sideoption (where applicable).ExchangeCalendarTestBasehas been significantly simplified.Answersclass which evaluates inputs from interrogation of aresources\*.csvfile.ExchangeCalendarTestBasesubclass to provide calendar specific inputs, for exampleregular_holidays_sample.ExchangeCalendarTestBase(only for rare cases where a fixture requires some knowledge of the calendar, for exampleearly_closesrequires knowledge of the rule governing prevailing normal close times).