feat: commando connector #1577

kiwiidb · 2022-10-06T20:28:36Z

Commando is implemented through the lnmessage library, thanks to @aaronbarnardsound. This library uses a websocket proxy (lnproxy.getalby.com) to communicate with a remote CLN node over the p2p port.

Features out of scope for this PR (but coming later):

Tor support
WebLN support for arbitrary CLN (+plugin) RPC calls
Finer grained permissions for WebLN calls
Stream network gossip to website over WebLN
I'm probably forgetting more awesome stuff

To test:

download and install the development build of this PR
Add a new connector, pick Core Lightning.
Go to here for the connection details of our testnet CLN node, or connect your own (mainnet or testnet) node.
Fill in the connection details
Try to spend and receive some sats on testnet.

Instruction video to test on mainnet: https://www.loom.com/share/359f2cf7e4764950983859301b6e9ecc

github-actions · 2022-10-06T20:35:04Z

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

This build is brought to you by: Adam Fiscor (who recently dropped 1337 sats):

The future is bright. We just have a lot of work to do.

Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

src/extension/background-script/connectors/commando.ts

socket-security · 2022-10-24T07:34:29Z

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary

Issue	Status
Install scripts	✅ 0 issues
Native code	✅ 0 issues
Bin script confusion	✅ 0 issues
Bin script shell injection	✅ 0 issues
Unresolved require	✅ 0 issues
Invalid package.json	✅ 0 issues
HTTP dependency	✅ 0 issues
Git dependency	✅ 0 issues
Potential typo squat	✅ 0 issues
Known Malware	✅ 0 issues
Telemetry	✅ 0 issues
Protestware/Troll package	✅ 0 issues

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

escapedcat · 2022-10-24T09:53:54Z

bumi noticed: package-lock.json can be removed. We use yarn and yarn.lock.

bumi

package-lock must not be in the repo. we use yarn.

kiwiidb · 2022-10-26T08:39:52Z

Updated with fixes for some of @bumi 's remark. I don't know anything about the webpack/storyboard stuff though.

bumi · 2022-10-28T20:11:00Z

.storybook/main.js

@@ -32,6 +32,12 @@ module.exports = {
      ],
      include: path.resolve(__dirname, "../"),
    });
+    config.module.rules.push({


what's with the following package.json keys:
source, main, unpkg, exports ?

packages that can run in different environments should publish the package valid for the different environments.

Does the build step need to be improved? https://github.com/aaronbarnardsound/lnmessage/blob/master/package.json#L14
tsc is not enough?

I don't know enough about the build setups in 2022, but I used microbundle recently in this package: https://github.com/getAlby/alby-tools/blob/master/package.json#L28

src/app/screens/connectors/ConnectCommando/index.tsx

# By Lisa Oppermann (15) and others # Via GitHub (22) and others * master: (57 commits) fix: publisher link on AllowanceView Translated using Weblate (Italian) Update all development Yarn dependencies (2022-10-29) fix: align reject/close function params fix: navigate on send Update dayjs to version 1.11.6 fix: disable input fields on Create Invoice #1659 (#1668) Update react-i18next to version 12.0.0 Push buttons to bottom in Send and Receive Screens (#1672) refactor(lnurl): getDetails - avoid typecasting (#1545) style: prettier Translated using Weblate (Italian) Update tailwindcss to version 3.2.1 style: prettier Translated using Weblate (Portuguese (Brazil)) style: prettier Translated using Weblate (Italian) Translated using Weblate (Swedish) fix: remove response and additional error message fix: use math floor everywhere ... # Conflicts: # yarn.lock

src/i18n/locales/en/translation.json

src/app/router/connectorRoutes.tsx

src/extension/background-script/connectors/commando.ts

bumi · 2022-11-08T23:15:19Z

webpack.config.js

+        test: /\.m?js/,
+        resolve: {
+          fullySpecified: false
+        }


@escapedcat what's the status here?
this still can not be removed?

Unfortunately not: lnbc1QWFyb24/lnmessage#3 (comment)

# By Adithya Vardhan (9) and others # Via GitHub (19) and escapedcat (1) * master: (34 commits) chore: fix lodash types and reduce package size chore: remove storybook github action chore: remove storybook stories chore: remove storybook config docs: adjust storybook info chore: remove storybook Translated using Weblate (Italian) fix: handle dexie in jest Update react-router-dom to version 6.4.3 Update i18next-browser-languagedetector to version 7.0.1 Update react-toastify to version 9.1.1 fix: yarn lock fix: use transformIgnorePatterns for dexie chore: remove unused runcitadel sdk prettier i18nConfig.ts feat(i18n): activate italian feat: handle organization pages fix: highlight menu icon dots fix: tipping in medium fix: fetch from description element ... # Conflicts: # .storybook/main.js # package.json # yarn.lock

* master: (24 commits) feat: commando connector (#1577) chore: type the lnurl params chore: fix lodash types and reduce package size chore: remove storybook github action chore: remove storybook stories chore: remove storybook config docs: adjust storybook info chore: remove storybook Translated using Weblate (Italian) fix: handle dexie in jest Update react-router-dom to version 6.4.3 Update i18next-browser-languagedetector to version 7.0.1 Update react-toastify to version 9.1.1 fix: yarn lock fix: use transformIgnorePatterns for dexie chore: remove unused runcitadel sdk prettier i18nConfig.ts feat(i18n): activate italian feat: handle organization pages fix: highlight menu icon dots ...

# By Michael Bumann (10) and others # Via GitHub (18) and others * master: (38 commits) chore: update node version docs: add md line-break docs: remove nodenv support info chore: use node 18 in the GH workflows chore: default to the latest LTS version (when using nvm) chore: remove node version lock fix: decrease spacing between elements to fit into screen build(jest): compile lnmessage to avoid module issue feat: commando connector (#1577) chore: type the lnurl params chore: fix lodash types and reduce package size chore: remove storybook github action chore: remove storybook stories chore: remove storybook config docs: adjust storybook info chore: remove storybook Translated using Weblate (Italian) fix: handle dexie in jest Update react-router-dom to version 6.4.3 Update i18next-browser-languagedetector to version 7.0.1 ... # Conflicts: # src/extension/background-script/connectors/index.ts

# By Adithya Vardhan (8) and others # Via GitHub (14) and others * master: (25 commits) build(jest): compile lnmessage to avoid module issue feat: commando connector (#1577) chore: type the lnurl params chore: fix lodash types and reduce package size chore: remove storybook github action chore: remove storybook stories chore: remove storybook config docs: adjust storybook info chore: remove storybook Translated using Weblate (Italian) fix: handle dexie in jest Update react-router-dom to version 6.4.3 Update i18next-browser-languagedetector to version 7.0.1 Update react-toastify to version 9.1.1 fix: yarn lock fix: use transformIgnorePatterns for dexie chore: remove unused runcitadel sdk prettier i18nConfig.ts feat(i18n): activate italian feat: handle organization pages ... # Conflicts: # package.json # src/app/router/connectorRoutes.tsx # yarn.lock

feat: start commando connector

0ac3c0c

kiwiidb mentioned this pull request Oct 6, 2022

Commando (CLN) connector #1390

Closed

escapedcat and others added 3 commits October 7, 2022 12:39

chore: storybook - apply webpack mjs config

3423c23

feat: implement get balance

45d3f40

feat: add make invoice call

a357be4

bumi reviewed Oct 17, 2022

View reviewed changes

src/extension/background-script/connectors/commando.ts Show resolved Hide resolved

kiwiidb added 12 commits October 18, 2022 10:14

chore: bump lnmessage dep

b570402

feat: add connectpeer call

be103cf

feat: implement getinvoice response

95f6c41

feat: implement payinvoice response

1463471

feat: implement checkinvoice response

7948844

feat: implement missing methods

8649592

chore: consistent params

1b68578

fix: disconnect on unload

f096ac3

feat: commando: add proxy and peer options

b955f77

feat: improve commando connector page

4342c28

fix: update lnmessage version

9b30c4e

chore: fix merge conflicts

05c38d9

feat: add private key

ff74995

kiwiidb changed the title ~~feat: start commando connector~~ feat: commando connector Oct 24, 2022

kiwiidb marked this pull request as ready for review October 24, 2022 08:39

kiwiidb requested review from escapedcat, bumi and reneaaron October 24, 2022 08:58

bumi requested changes Oct 24, 2022

View reviewed changes

kiwiidb added 2 commits October 24, 2022 15:12

fix: translation + keysend

62f7ae0

chore: remove package lock file

588c248

bumi reviewed Oct 28, 2022

View reviewed changes

escapedcat mentioned this pull request Oct 31, 2022

Question: NodeJs support lnbc1QWFyb24/lnmessage#3

Closed

kiwiidb force-pushed the feature/commando-connector branch from 0e892a0 to 34c29aa Compare November 1, 2022 07:29

bumi and others added 2 commits November 1, 2022 10:30

fix: use number field, no need to parse strings, my mistake

d2e0e63

bumi reviewed Nov 4, 2022

View reviewed changes

src/i18n/locales/en/translation.json Show resolved Hide resolved

bumi reviewed Nov 4, 2022

View reviewed changes

src/app/router/connectorRoutes.tsx Show resolved Hide resolved

kiwiidb added 4 commits November 4, 2022 13:00

chore: remove unnecessary code

67353f7

chore: 3 ='s

45efa02

feat: add advanced settings

884c5f3

chore: update yarn lock

af591da

kiwiidb requested review from bumi and escapedcat November 4, 2022 12:16

kiwiidb added 2 commits November 4, 2022 13:22

chore: use math.floor

bb971f1

fix: msatoshi_sent

6aaab06

kiwiidb requested a review from reneaaron November 4, 2022 12:29

kiwiidb added 5 commits November 4, 2022 13:55

feat: translation advanced

d07982a

feat: disable getinvoices

d3e4a94

chore: add test

7876df6

feat: listinvoices

149c26e

fix: milliseconds

15d1a74

bumi reviewed Nov 6, 2022

View reviewed changes

src/extension/background-script/connectors/commando.ts Outdated Show resolved Hide resolved

bumi reviewed Nov 8, 2022

View reviewed changes

bumi merged commit 9d213ce into master Nov 9, 2022

bumi deleted the feature/commando-connector branch November 9, 2022 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: commando connector #1577

feat: commando connector #1577

kiwiidb commented Oct 6, 2022 •

edited

Loading

github-actions bot commented Oct 6, 2022 •

edited

Loading

socket-security bot commented Oct 24, 2022 •

edited

Loading

escapedcat commented Oct 24, 2022

bumi left a comment

kiwiidb commented Oct 26, 2022

bumi Oct 28, 2022

bumi Nov 8, 2022

escapedcat Nov 9, 2022

feat: commando connector #1577

feat: commando connector #1577

Conversation

kiwiidb commented Oct 6, 2022 • edited Loading

github-actions bot commented Oct 6, 2022 • edited Loading

socket-security bot commented Oct 24, 2022 • edited Loading

Socket Security Pull Request Report

escapedcat commented Oct 24, 2022

bumi left a comment

Choose a reason for hiding this comment

kiwiidb commented Oct 26, 2022

bumi Oct 28, 2022

Choose a reason for hiding this comment

bumi Nov 8, 2022

Choose a reason for hiding this comment

escapedcat Nov 9, 2022

Choose a reason for hiding this comment

kiwiidb commented Oct 6, 2022 •

edited

Loading

github-actions bot commented Oct 6, 2022 •

edited

Loading

socket-security bot commented Oct 24, 2022 •

edited

Loading