feat: implemented nip04 #1777
Merged
feat: implemented nip04 #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. Don't forget: keep earning sats! |
bumi
reviewed
Nov 25, 2022
bumi
reviewed
Nov 27, 2022
|
|
||
| encrypt(pubkey: string, text: string) { | ||
| const key = secp256k1.getSharedSecret(this.getPrivateKey(), "02" + pubkey); | ||
| const normalizedKey = Buffer.from(key.slice(1, 33)); |
There was a problem hiding this comment.
what is this doing?
should this be a compressed key?
https://www.npmjs.com/package/@noble/secp256k1#getsharedsecretprivatekeya-publickeyb
isCompressed = false determines whether to return compact (33-byte), or full (65-byte) key
| @@ -36,6 +42,35 @@ class Nostr { | |||
| event.sig = signature; | |||
| return event; | |||
| } | |||
|
|
|||
| encrypt(pubkey: string, text: string) { | |||
| const key = secp256k1.getSharedSecret(this.getPrivateKey(), "02" + pubkey); | |||
src/extension/background-script/actions/nostr/decryptOrPrompt.ts
Outdated
Show resolved
Hide resolved
src/extension/background-script/actions/nostr/encryptOrPrompt.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
Implement NIP04:
encrypt&decryptLink this PR to an issue [optional]
#1730
Type of change
feat: New feature (non-breaking change which adds functionality)