Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nostr permissions + nip04 #1793

Conversation

bumi
Copy link
Collaborator

@bumi bumi commented Nov 29, 2022

adding the permissions to then nip04 calls from #1777

  • This shows the duplication in the current setup. How should we refactor this?
  • could this be a general Confirm screen? @reneaaron I actually was wondering how useful it is to show the data that is signed/encrypted? Can this also be a huge blob of text/data?

escapedcat and others added 30 commits November 22, 2022 17:53
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
Co-authored-by: Michael Bumann <hello@michaelbumann.com>
…gn-message-bumi-nip04

# By René Aaron
# Via GitHub
* feature/nostr-nip04:
  Update src/extension/background-script/actions/nostr/encryptOrPrompt.ts
  Update src/extension/background-script/actions/nostr/decryptOrPrompt.ts
  fix: ts fixes
  fix: ts fixes
  fix: ts fixes
  fix: refactored encrypto to crypto-js
  fix: refactored decrypt to crypto-js
  fix: added test
  feat: implemented nip04

# Conflicts:
#	src/extension/content-script/onendnostr.js
@github-actions
Copy link

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.

Don't forget: keep earning sats!

@escapedcat escapedcat force-pushed the feat/1727_nostr-permission-sign-message-bumi branch from 2150c92 to 3bc91d7 Compare November 29, 2022 15:04
@bumi bumi closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants