Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changed the connector pages for Umbrel and LNC #2325

Closed
wants to merge 3 commits into from

Conversation

mviswanathsai
Copy link
Contributor

Describe the changes you have made in this PR

Updated the LNC and Umbrel connector pages.

Link this PR to an issue [optional]

Fixes _#2258

Type of change

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

Current connector pages for the Umbrel and LNC pages respectively:

Screenshot 2023-04-08 225747

Screenshot 2023-04-08 225804

How has this been tested?

Tested manually to see if the desired changes are reflected

Checklist

  • [ x] My code follows the style guidelines of this project and performed a self-review of my own code
  • [x ] New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@socket-security
Copy link

socket-security bot commented Apr 8, 2023

No dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

@mviswanathsai mviswanathsai changed the title Viswa patch feat: Changed the connector pages for Umbrel and LNC Apr 8, 2023
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@reneaaron
Copy link
Contributor

Closing in favor of #2326

@reneaaron reneaaron closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants