feat:store additional data with permissions #3035
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
prototype to store nostr permssions in db.
looking over the designs and code i think we don't need to add additional data in the db for permissions and we can achieve it without such changes. as such changes will also need migrations.
we store
enabled
property to true when we add permissions and set it to false when we revoke permissions so we don't need to store allow and deny as well we can use this variable and just change ui to use buttons which to allow or revoke a permissionstype definitions: type definitions are incomplete for event kinds we need to add type definitions
From the above explanation, i think we can achieve permission management without storing additional metadata. wdyt @reneaaron