feat: kind based nostr permissions #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneaaron
changed the title
add hover states to badges
pavanjoshi914
changed the title
reneaaron
reviewed
Mar 18, 2024
reneaaron
requested changes
Mar 18, 2024
bumi
reviewed
Mar 19, 2024
src/extension/background-script/actions/nostr/signEventOrPrompt.ts
Outdated
Show resolved
Hide resolved
reneaaron
requested changes
Mar 19, 2024
There was a problem hiding this comment.
NIP04 / NIP44 translations are currently missing, please just use "Decrypt / Encrypt data", no mention of NIP04 / NIP44 - users won't know what this is.
Can we possibly also merge them into one nostr/encrypt / nostr/decrypt permission? For a user I think it makes no difference which internal method is used to encrypt / decrypt data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
kind based nostr permissions + overall permission refactoring in extension
Type of change
feat: New feature (non-breaking change which adds functionality)How has this been tested?
try permisisons functionality
Checklist