-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade webextension-polyfill: 0.8.0 → 0.9.0 (major) #768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damn, this update breaks the tests |
Found these:
|
depfu
bot
force-pushed
the
depfu/update/yarn/webextension-polyfill-0.9.0
branch
from
April 13, 2022 22:10
cb6cdac
to
0a7acfc
Compare
depfu
bot
force-pushed
the
depfu/update/yarn/webextension-polyfill-0.9.0
branch
from
April 25, 2022 15:15
0a7acfc
to
0989aec
Compare
escapedcat
force-pushed
the
depfu/update/yarn/webextension-polyfill-0.9.0
branch
from
May 4, 2022 02:16
c4e8bb3
to
a87efce
Compare
escapedcat
reviewed
May 4, 2022
// avoid "This script should only be loaded in a browser extension." issue | ||
// https://github.com/clarkbw/jest-webextension-mock/issues/149#issuecomment-1116307310 | ||
// @ts-ignore: chrome available during tests via jest-webextension-mock | ||
if (!chrome.runtime) chrome.runtime = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not actually sure were chrome
is coming from during the tests. I assume via web-extension-mock
but not sure how to satisfy TS here.
Closing because this update has already been applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ webextension-polyfill (0.8.0 → 0.9.0) · Repo
Release Notes
0.9.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 21 commits:
chore: bump version for release 0.9.0
chore(deps): update dependency mocha to v9 (#324)
chore(ci): Updated circleci to use the new cimg/node docker images (#371)
chore(deps): update dependency istanbul-lib-instrument to v5 (#338)
chore(deps): update codecov orb to v3.2.2 (#352)
chore(deps): update dependency shelljs to v0.8.5 [security] (#358)
chore: Run update apt before installing xserver-xephyr in the CI job (#359)
fix: enable webextension-polyfill usage via webpack ProvidePlugin (#351)
chore: Update eslint to enforce quotes and fix the existing linting errors (#355)
chore(deps): update dependency chromedriver to v96
chore: Bump nodejs version used by CircleCI jobs to nodejs v12
chore: Fix missing codecov reports (#345)
Use new codecov uploader via Circle ORB (#341)
docs: Updated readme for @types/webextension-polyfill (#330)
chore(deps): update babel monorepo (#305)
chore(deps): update dependency mocha to v8.4.0 (#314)
chore(deps): update dependency codecov to v3.8.2 (#310)
chore(deps): update dependency eslint to v7.25.0 (#308)
chore(deps): update dependency grunt-replace to v2.0.2 (#309)
chore(deps): update dependency grunt to v1.4.0 (#306)
chore(deps): update dependency chromedriver to v90 (#304)
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands