-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tipping support for mastodon #826
base: master
Are you sure you want to change the base?
Conversation
ebd7a0c
to
790d175
Compare
@bumi I just added tipping support for Mastodon instances. There are a few questions left that I wanted to clarify before submitting the MR for review:
|
"", | ||
description: | ||
document.querySelector( | ||
".public-account-bio, .account__header__bio .account__header__content" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is to broad. when a user has profile metadata then this is also in the description.
Here is a list of instances: https://joinmastodon.org/communities |
maybe we can also make a PR to officially add it to Mastodon: https://github.com/mastodon/mastodon ? |
the twitter poll: https://twitter.com/getAlby/status/1520899495835635712 |
@reneaaron could you send me a screenshot of a profile on mastodon with a Lightning Address? I want to update the designs on getalby.com/value4value |
I think that would generally be preferable, since there are so many instances that you can't really have a whitelist for it. I was thinking about this in the past, and I think the cleanest way would be to add a new Mastodon user preference for adding a Lightning Address to a user profile, which could then be fetched by any other user and software (Mastodon is just one out of many ActivityPub applications). And the user's client could then implement the payment flow via the Lightning Address and using WebLN, and whatever integration is best for native mobile apps on the various mobile operating systems. To improve things for users even further, fediverse server providers can then also go ahead and offer sats inboxes for their local users, and pre-configure local Lightning Addresses for them (same as the normal user address). This is what we had planned to do with kosmos.social, once we have the user base there ported to our LDAP server, where we already offer Lightning accounts to all kosmos.org users. |
import setLightningData from "../setLightningData"; | ||
|
||
const urlMatcher = | ||
/^https:\/\/(bitcoinhackers\.org|kosmos\.social)\/(web\/)?@\S+/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no way to generalize this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could check the actual HTML code, but we wanted to avoid this initially.
Do you think it's OK to do that?
There's an existing convention for cryptocurrency donation addresses: metadata fields with labels like $BTC, $ETH etc. I've never seen anything like $LN though |
|
I don't know, which one do you think Alby users would prefer? |
Link this PR to an issue
Fixes #476
Type of change (Remove other not matching type)
Describe the changes you have made in this PR -
Tipping support for Mastodon instances.
How Has This Been Tested?
✅ Tipped on bitcoinhackers.com
Checklist: