Dialogs with multiple possible actions look bad

[lognaturel]

It's no longer very clear that save or ignore changes are clickable:

I looked through the material design guidelines and would like to propose something like the following:

Disclaimer, I am not a designer and certainly open to other ideas! The icons should probably be tinted with the accent color. @shobhitagarwal1612 it would be good to get your feedback.

From what I understand, material design would suggest automatically saving and not presenting this kind of dialog at all. This can certainly be reviewed at some point, but for now I think it would be best to make the dialog more usable and fit in with other dialogs that now roughly follow material design guidelines.

Note that the guidelines explicitly state that this kind of dialog should have no cancel button and that the user should just use the back button or tapping outside the dialog to dismiss it. The cancel button has been on that dialog for a long time, though, and I think it's better not to assume that users know those other ways of dismissing dialogs.

[shobhitagarwal1612]

Sorry for the late response. How about breaking this into two dialogs?

First one would be :

Exit All Dialogs?

        No   Yes 

If user presses Yes then :

Save changes?

      No   Yes

[YuraLaguta]

IMHO two clicks will be more annoying.
When I'm exiting Writing a new email screen in (Gmail app) it's Saves it automatically as a draft. And shows Toast.

Calendar on the other hand shows:

when I try to exist just create event.

Should we drop the icons? It looks much cleaner without them.

Maybe something like:
"Leaving All Widget form with unsaved changes?"
'Cancel' 'Discard' 'Save'

[lognaturel]

The double dialog does seem like it would be more disruptive so I'm not sure I like it very much.

@Yurii-Laguta when you say drop the icons, do you just mean leaving it as it is currently? Perhaps just making sure cancel is on the right and in uppercase and dropping the icon would make it look better. I wouldn't be opposed to doing just that.

The problem with three buttons side by side is that we do need to support small screens and multiple languages.

[YuraLaguta]

@lognaturel I mean don't show any icons. On the second thought Action icons look good, but not the title.

I see the 3 button won't work.

How about Bottom sheet dialog? Similar to Google Photos app, it's nicely dismissible with swipe down or back button, will it be too much learning curve for user?
Another advantage it's close to the back button, so it's less disruptive than dialog in the centre.

[YuraLaguta]

Started working on it.
[Off topic] is there a way to self assign issue?

[YuraLaguta]

@lognaturel is that something you had in mind?:

To me this one looks better:

[YuraLaguta]

Here is version with bigger icons and smaller text

[lognaturel]

@Yurii-Laguta unfortunately there isn't a way to self-assign issues yet but hopefully that will come very soon. See https://forum.opendatakit.org/t/fine-grained-permissions-for-github-issues-self-assign-labels/9352 for where we're at and please jump in if you have any other ideas!

I am intrigued by the bottom sheet idea and I hadn't noticed that interface before. I think the situation may be a little different. In the Google Photos, the bottom sheet shows up when a user taps the trashcan icon. The back button hides the bottom sheet when it's out. In the Collect case, the back button would trigger the bottom sheet. I suppose tapping the back button again would also hide the sheet / cancel. That seems like it could be a somewhat unexpected interaction.

@wonderchook, @hooverlunch you both have a good feel for what your respective users need. Do you have any opinions on this issue and proposed changes?

[smoyte]

This all looks good to me. :)

[YuraLaguta]

@lognaturel very good point, I see now that bottom sheet is not suitable for this use case.
Please let me know if any changes required.

[lognaturel]

The form exit dialog has been updated. It would be good to reuse the same layout and look for the draw/signature/annotate widgets.

[shobhitagarwal1612]

Fixed in #1360

[lognaturel]

Let's keep open until the draw/signature/annotate menu uses the same look and feel!

[YuraLaguta]

@lognaturel would you assign it to me and please point in direction of how to get to draw/signature/annotane menus On 4 Sep. 2017 7:26 am, "Hélène Martin" <notifications@github.com> wrote: Let's keep open until the draw/signature/annotate menu uses the same look and feel! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1265 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABxGc1x_h1LRuiDfhpSXEaiCkF0mHySRks5sexmOgaJpZM4Odd6-> .

[lognaturel]

Awesome, thanks @Yurii-Laguta! Take a look at createQuitDrawDialog() in DrawActivity.

[getodk-bot]

ERROR: This issue is in progress, but has no assignee.

[YuraLaguta]

@opendatakit-bot assignToMe

[lognaturel]

Our poor bot is not all that clever, @Yurii-Laguta. 😕 The only command it understands to assign issues is "claim" so you would type opendatakit-bot claim. You can check out the other commands it understands at https://github.com/opendatakit/zulipbot/blob/master/src/config.js

[YuraLaguta]

thanks @lognaturel
@opendatakit-bot claim

[getodk-bot]

Welcome to Open Data Kit, @Yurii-Laguta! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

• Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
• Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
• Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!