-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1265 Update quit dialog for DrawWidget #1494
1265 Update quit dialog for DrawWidget #1494
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1494 +/- ##
==========================================
- Coverage 19.37% 14.02% -5.36%
==========================================
Files 231 231
Lines 21275 21198 -77
Branches 2757 2739 -18
==========================================
- Hits 4122 2972 -1150
- Misses 16614 17846 +1232
+ Partials 539 380 -159
Continue to review full report at Codecov.
|
Tested with success.
Tested on Android 4.1, 4.2, 4.4, 5.1, 6.0, 7.0. |
🎉🎉🎉 |
@opendatakit-bot unlabel "needs testing" |
Closes #1265
What has been done to verify that this works as intended?
Launch on emulator and tested all the possible outcome.
Why is this the best possible solution? Were any other approaches considered?
Same approach as the FormEntryActivity
Are there any risks to merging this code? If so, what are they?
No.