Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1265 Update quit dialog for DrawWidget #1494

Merged

Conversation

YuraLaguta
Copy link
Contributor

Closes #1265

What has been done to verify that this works as intended?

Launch on emulator and tested all the possible outcome.

Why is this the best possible solution? Were any other approaches considered?

Same approach as the FormEntryActivity

Are there any risks to merging this code? If so, what are they?

No.

@YuraLaguta
Copy link
Contributor Author

screenshot 2017-09-24 21 11 57

Design same as in FormEntryActivity

@codecov-io
Copy link

Codecov Report

Merging #1494 into master will decrease coverage by 5.35%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1494      +/-   ##
==========================================
- Coverage   19.37%   14.02%   -5.36%     
==========================================
  Files         231      231              
  Lines       21275    21198      -77     
  Branches     2757     2739      -18     
==========================================
- Hits         4122     2972    -1150     
- Misses      16614    17846    +1232     
+ Partials      539      380     -159
Impacted Files Coverage Δ
...g/odk/collect/android/activities/DrawActivity.java 0% <0%> (ø) ⬆️
...org/odk/collect/android/widgets/IntegerWidget.java 0% <0%> (-75%) ⬇️
...ct/android/widgets/SelectOneAutoAdvanceWidget.java 0% <0%> (-72.73%) ⬇️
...odk/collect/android/widgets/SelectMultiWidget.java 0% <0%> (-71.43%) ⬇️
...g/odk/collect/android/widgets/ExDecimalWidget.java 0% <0%> (-70%) ⬇️
...g/odk/collect/android/widgets/SelectOneWidget.java 0% <0%> (-69.12%) ⬇️
...org/odk/collect/android/widgets/BooleanWidget.java 0% <0%> (-68.97%) ⬇️
...g/odk/collect/android/widgets/ExIntegerWidget.java 0% <0%> (-64.71%) ⬇️
...dk/collect/android/widgets/SpinnerMultiWidget.java 0% <0%> (-62.66%) ⬇️
...collect/android/widgets/SelectOneSearchWidget.java 0% <0%> (-60%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9049cc6...e3ed4a2. Read the comment docs.

@mmarciniak90
Copy link
Contributor

Tested with success.
Expected dialog is visible on questions:

  • Draw widget
  • Annotate widget
  • Signature widget

Tested on Android 4.1, 4.2, 4.4, 5.1, 6.0, 7.0.
On Android 4.1 is visible problem #1493 but when both issues will be merged to master branch everything should be OK.

@lognaturel lognaturel merged commit 6fec181 into getodk:master Sep 25, 2017
@lognaturel
Copy link
Member

🎉🎉🎉

@mmarciniak90
Copy link
Contributor

@opendatakit-bot unlabel "needs testing"

shobhitagarwal1612 pushed a commit to shobhitagarwal1612/collect that referenced this pull request May 15, 2018
snavarreteimmap pushed a commit to snavarreteimmap/collect that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants