Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lifecycle logging from FormFillingActivity #5637

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Jun 20, 2023

These were added as part of investigating #5241 which we've now closed. It looks like one of the logs was actually causing a crash, so I though it would make sense to just remove them.

If others feel we should keep them in, we could pull out a helper method that can safely create a hash if the data portion of the Intent is null as an alternative to removing them.

@seadowg seadowg marked this pull request as ready for review June 20, 2023 16:36
@seadowg seadowg requested a review from grzesiek2010 June 20, 2023 16:36
@grzesiek2010 grzesiek2010 merged commit 7374f21 into getodk:master Jun 21, 2023
@seadowg seadowg deleted the remove-logging branch June 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants