Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lifecycle logging from FormFillingActivity #5637

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Remove lifecycle logging from FormFillingActivity #5637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions collect_app/src/main/java/org/odk/collect/android/activities/FormFillingActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@
import org.odk.collect.permissions.PermissionsProvider;
import org.odk.collect.settings.SettingsProvider;
import org.odk.collect.settings.keys.ProjectKeys;
import org.odk.collect.shared.strings.Md5;
import org.odk.collect.strings.localization.LocalizedActivity;

import java.io.File;
Expand Down Expand Up @@ -393,8 +392,6 @@ public void allowSwiping(boolean doSwipe) {
*/
@Override
public void onCreate(Bundle savedInstanceState) {
Timber.w("onCreate %s", Md5.getMd5Hash(getIntent().getData().toString()));

// Workaround for https://issuetracker.google.com/issues/37124582. Some widgets trigger
// this issue by including WebViews
if (Build.VERSION.SDK_INT >= 24) {
Expand Down Expand Up @@ -780,8 +777,6 @@ private FormController getFormController() {

@Override
protected void onSaveInstanceState(Bundle outState) {
Timber.w("onSaveInstanceState %s", Md5.getMd5Hash(getIntent().getData().toString()));

super.onSaveInstanceState(outState);

outState.putString(KEY_SESSION_ID, sessionId);
Expand Down Expand Up @@ -1843,8 +1838,6 @@ private void updateNavigationButtonVisibility() {

@Override
protected void onStart() {
Timber.w("onStart %s", Md5.getMd5Hash(getIntent().getData().toString()));

super.onStart();
FormController formController = getFormController();

Expand All @@ -1863,17 +1856,13 @@ && new PlayServicesChecker().isGooglePlayServicesAvailable(this)) {

@Override
protected void onPause() {
Timber.w("onPause %s", Md5.getMd5Hash(getIntent().getData().toString()));

backgroundLocationViewModel.activityHidden();

super.onPause();
}

@Override
protected void onResume() {
Timber.w("onResume %s", Md5.getMd5Hash(getIntent().getData().toString()));

super.onResume();

activityDisplayed();
Expand Down Expand Up @@ -1976,8 +1965,6 @@ public boolean onKeyDown(int keyCode, KeyEvent event) {

@Override
protected void onDestroy() {
Timber.w("onDestroy %s", Md5.getMd5Hash(getIntent().getData().toString()));

if (formLoaderTask != null) {
formLoaderTask.setFormLoaderListener(null);
// We have to call cancel to terminate the thread, otherwise it
Expand Down