Fixed setting up the sort menu #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-5856
branch
from
fab013b to
f7d4390
Compare
seadowg
approved these changes
Jan 8, 2024
| @@ -36,4 +38,18 @@ public void deletingAForm_removesFormFromFinalizedForms() { | |||
| .pressBack(new MainMenuPage()) | |||
| .assertNumberOfFinalizedForms(0); | |||
| } | |||
|
|
|||
| @Test | |||
| public void accessingSortMenuInDeleteSavedInstancesShouldNotCrashTheAppAfterRotatingTheDevice() { | |||
There was a problem hiding this comment.
I was hoping I could say "this could be a test for XFragment, but deleting a saved form still uses AppListFragment sadly! Hopefully this kind of test can be moved down to a Fragment level when we make the same changes we made for deleting blank forms (creating DeleteBlankFormFragment for example).
|
Tested with Success! Verified on device with Android 12,13 Verified cases;
|
|
Tested with Success! Verified on device with Android 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5856
Why is this the best possible solution? Were any other approaches considered?
We should use
getSelectedSortingOrder()method to make sure the returned value is not null instead of directly accessingselectedSortingOrderfield.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It's a safe and isolated change so we can focus on verifying that the problem described in the issue is fixed.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still pass