Run tests against API 34 device #6059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
force-pushed
the
api-34-tests
branch
2 times, most recently
from
83908a5 to
b746aa1
Compare
seadowg
commented
Apr 4, 2024
| --results-bucket opendatakit-collect-test-results \ | ||
| --directories-to-pull /sdcard --timeout 20m | ||
| --directories-to-pull /sdcard --timeout 20m \ | ||
| --test-targets "notPackage org.odk.collect.android.regression" |
There was a problem hiding this comment.
I've disabled regression tests for now as they'll be reworked in #5983.
seadowg
commented
Apr 8, 2024
| @@ -15,6 +16,7 @@ | |||
| import org.odk.collect.android.support.rules.TestRuleChain; | |||
| import org.odk.collect.testshared.RecyclerViewMatcher; | |||
|
|
|||
| @Ignore | |||
There was a problem hiding this comment.
These tests are flaking out a lot. I'm actually not convinced that there isn't some problem in the repeat delete flows, but it's definitely not something I wanted to go deep on here. I'll create another issue to cover this.
grzesiek2010
requested changes
Apr 9, 2024
collect_app/src/androidTest/java/org/odk/collect/android/support/rules/RecentAppsRule.kt
Outdated
Show resolved
Hide resolved
| @@ -50,8 +51,18 @@ protected boolean matchesSafely(ImageView imageView) { | |||
|
|
|||
| Bitmap actual = ((BitmapDrawable) drawable).getBitmap(); | |||
|
|
|||
| return actual.sameAs(match); | |||
| StrictMode.ThreadPolicy originalThreadPolicy = StrictMode.getThreadPolicy(); | |||
There was a problem hiding this comment.
What was the problem here (without your changes)?
There was a problem hiding this comment.
There's a comment below:
Permit slow calls to allow
sameAsuse
collect_app/src/androidTest/java/org/odk/collect/android/feature/smoke/AllWidgetsFormTest.java
Show resolved
Hide resolved
collect_app/src/androidTest/java/org/odk/collect/android/feature/smoke/AllWidgetsFormTest.java
Show resolved
Hide resolved
collect_app/src/androidTest/java/org/odk/collect/android/support/rules/RecentAppsRule.kt
Outdated
Show resolved
Hide resolved
collect_app/src/androidTest/java/org/odk/collect/android/support/rules/RecentAppsRule.kt
Outdated
Show resolved
Hide resolved
collect_app/src/androidTest/java/org/odk/collect/android/support/rules/RecentAppsRule.kt
Outdated
Show resolved
Hide resolved
collect_app/src/androidTest/java/org/odk/collect/android/support/DummyActivityLauncher.kt
Outdated
Show resolved
Hide resolved
...ect_app/src/androidTest/java/org/odk/collect/android/support/rules/NotificationDrawerRule.kt
Outdated
Show resolved
Hide resolved
View hierarchies logged on a `NoMatchingViewException` are truncated after a max line length, but are then written out to a file. This means we need to pull the `/sdcard` to make sure we have access to the file.
grzesiek2010
approved these changes
Apr 10, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a few observations from playing around with getting the tests more stable (and moving them to API 34):
inRootor you're at the mercy of Espresso's built in "heuristic" window chooser (https://developer.android.com/training/testing/espresso/recipes) and that doesn't always get it right.perform(click())doesn't seem to work all the time.click()injects events into the UI instead of usingperformClick()on the view directly (which may be to catch problems with obscured views), and it seems like this sometimes doesn't end up propagating to the expected view.IdlingResourcemagic - there's no provided way to deal with Kotlin Coroutines or Data Binding for instance. Given this, it's very hard to trust that there aren't other moving parts deep in the view rendering that aren't being accounted for.UIDevicedirectly is still the only real option for flows that need rotation.Due to 3 and 4, I've ended up expanding our use of
WaitFor.waitFor()andWaitFor.tryAgainOnFail()quite a bit. Other than that, the largest changes are probably to the (new)RecentAppsRuleand toNotificationDrawerto get them working with API 34 (as well as continuing support for API 30).