Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent resetting finalized forms that modify entities #6460

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Oct 16, 2024

Closes #6435

Why is this the best possible solution? Were any other approaches considered?

Not a lot to discuss here! I just piggy backed on the existing helpers added to determine whether a form can safely be deleted and added a new use case for resetting entities now the logic is more complex than just deleting everything.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Just affects the saved form reset flow.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review October 16, 2024 15:16
@seadowg seadowg requested a review from grzesiek2010 October 16, 2024 15:16
@grzesiek2010 grzesiek2010 merged commit bfd0e38 into getodk:master Oct 24, 2024
6 checks passed
@seadowg seadowg deleted the reset-entities branch October 24, 2024 15:11
@WKobus
Copy link

WKobus commented Nov 4, 2024

Tested with Success

Verified on device with Android 15

Verified cases:

@dbemke
Copy link

dbemke commented Nov 4, 2024

Tested with Success

Verified on device with Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entities from finalized registration and update forms after resetting "saved forms and entities"
4 participants