Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant files cleaning during resetting saved forms #6477

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Oct 28, 2024

Closes #6475

Why is this the best possible solution? Were any other approaches considered?

We don't need the file cleaning that removes all instance directories, as when we reset specific instances (those that can be deleted), their files are removed automatically. See: https://github.com/getodk/collect/blob/master/collect_app/src/main/java/org/odk/collect/android/database/instances/DatabaseInstancesRepository.java#L153

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

We should test it in the same way as this pull request, as this is a fix for that specific PR.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@lognaturel lognaturel added the high priority Should be looked at before other PRs/issues label Oct 28, 2024
@grzesiek2010 grzesiek2010 requested a review from seadowg October 28, 2024 16:47
@grzesiek2010 grzesiek2010 marked this pull request as ready for review October 28, 2024 16:49
@grzesiek2010 grzesiek2010 merged commit 0233f66 into getodk:master Oct 29, 2024
6 checks passed
@WKobus
Copy link

WKobus commented Nov 4, 2024

Tested with Success

Verified on device with Android 15

Verified cases:

@dbemke
Copy link

dbemke commented Nov 4, 2024

Tested with Success

Verified on device with Android 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified high priority Should be looked at before other PRs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalized entity form gets deleted after resetting saved forms
5 participants