fix(brew): Replace version in artifact names with '__VERSION__' to access checksums from mustache #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checksums from mustache
tonyo
reviewed
Aug 29, 2023
romtsn
changed the title
tonyo
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a prerequisite for publishing sentry-wizard to brew (see getsentry/sentry-wizard#406)
When artifact names contain versions (e.g. sentry-wizard-v3.10.0.tgz), it's not possible to access their checksums when publishing to brew, because mustache does not support nested variables. The template for brew formula would have to look something like this, but I couldn't find how to make it work for mustache:
So this PR is simply replacing the version with
__VERSION__, if it appears to be in the name of the artifact, when building the checksums dictionary.Also updated readme to clarify the restrictions on the keys for checksums for the brew target.
Part of getsentry/sentry-wizard#346